From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] struct packed: Use gcc_struct on Windows
Date: Thu, 21 Jul 2022 19:03:14 +0300 [thread overview]
Message-ID: <83h73amp19.fsf@gnu.org> (raw)
In-Reply-To: <20220721152132.3489524-2-pedro@palves.net> (message from Pedro Alves on Thu, 21 Jul 2022 16:21:30 +0100)
> From: Pedro Alves <pedro@palves.net>
> Date: Thu, 21 Jul 2022 16:21:30 +0100
>
> The issue is that mingw gcc defaults to "-mms-bitfields", which
> affects how bitfields are laid out. We can however tell GCC that we
> want the regular GCC layout instead using attribute gcc_struct.
Is that a good idea? It means the code emitted by GCC for this source
file will be incompatible with any other library compiled with MinGW
that GDB uses. So we are risking ABI incompatibilities here. Right?
Can you tell why we must have the regular GCC layout of bitfields
here?
Thanks.
next prev parent reply other threads:[~2022-07-21 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:21 [PATCH 0/3] struct packed and Windows ports (PR build/29373) Pedro Alves
2022-07-21 15:21 ` [PATCH 1/3] struct packed: Use gcc_struct on Windows Pedro Alves
2022-07-21 16:03 ` Eli Zaretskii [this message]
2022-07-21 17:05 ` Pedro Alves
2022-07-21 17:40 ` Eli Zaretskii
2022-07-21 18:15 ` Pedro Alves
2022-07-21 18:23 ` Eli Zaretskii
2022-07-21 18:30 ` Pedro Alves
2022-07-21 18:45 ` Eli Zaretskii
2022-07-21 18:57 ` Pedro Alves
2022-07-21 18:18 ` Pedro Alves
2022-07-21 18:28 ` Eli Zaretskii
2022-07-21 18:38 ` Pedro Alves
2022-07-21 15:21 ` [PATCH 2/3] struct packed: Unit tests and more operators Pedro Alves
2022-07-21 15:21 ` [PATCH 3/3] struct packed: Add fallback byte array implementation Pedro Alves
2022-07-25 14:58 ` [PATCH 0/3] struct packed and Windows ports (PR build/29373) Tom Tromey
2022-07-25 15:18 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h73amp19.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).