From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] struct packed and Windows ports (PR build/29373)
Date: Mon, 25 Jul 2022 08:58:41 -0600 [thread overview]
Message-ID: <8735epjl26.fsf@tromey.com> (raw)
In-Reply-To: <20220721152132.3489524-1-pedro@palves.net> (Pedro Alves's message of "Thu, 21 Jul 2022 16:21:29 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> PR build/29373 points out that mingw GDB builds are brokenly current,
Pedro> failing static assertions in gdbsupport/packed.h. This series fixes
Pedro> it, for both mingw + gcc, and mingw + clang.
Please check these in. It would be good to have the Windows build
working again.
TBH I'm not sure any of this packed<> work is worth the effort,
especially after seeing what's necessary for clang. The memory savings
seem modest to me, considering that normally there aren't all that many
CUs. OTOH I'd prefer a fix to go in.
thanks,
Tom
next prev parent reply other threads:[~2022-07-25 14:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:21 Pedro Alves
2022-07-21 15:21 ` [PATCH 1/3] struct packed: Use gcc_struct on Windows Pedro Alves
2022-07-21 16:03 ` Eli Zaretskii
2022-07-21 17:05 ` Pedro Alves
2022-07-21 17:40 ` Eli Zaretskii
2022-07-21 18:15 ` Pedro Alves
2022-07-21 18:23 ` Eli Zaretskii
2022-07-21 18:30 ` Pedro Alves
2022-07-21 18:45 ` Eli Zaretskii
2022-07-21 18:57 ` Pedro Alves
2022-07-21 18:18 ` Pedro Alves
2022-07-21 18:28 ` Eli Zaretskii
2022-07-21 18:38 ` Pedro Alves
2022-07-21 15:21 ` [PATCH 2/3] struct packed: Unit tests and more operators Pedro Alves
2022-07-21 15:21 ` [PATCH 3/3] struct packed: Add fallback byte array implementation Pedro Alves
2022-07-25 14:58 ` Tom Tromey [this message]
2022-07-25 15:18 ` [PATCH 0/3] struct packed and Windows ports (PR build/29373) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735epjl26.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).