From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: add gdb.Architecture.format_address
Date: Tue, 22 Feb 2022 16:48:46 +0200 [thread overview]
Message-ID: <83ilt7t0s1.fsf@gnu.org> (raw)
In-Reply-To: <87sfsbattq.fsf@redhat.com> (message from Andrew Burgess on Tue, 22 Feb 2022 13:56:17 +0000)
> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 22 Feb 2022 13:56:17 +0000
>
> So, appologies, but this is another complete rewrite of the docs. With
> the exception of the name, for which I still have no better suggestions,
> how's this?
Let's see...
> +@defun Architecture.format_address (@var{address})
> +Return a string in the format @samp{@var{addr}
> +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address}
> +formatted in hexadecimal, @var{symbol} is the closest earlier symbol
> +to @var{address}, and @var{offset} is the offset from @var{symbol} to
> +@var{address} in decimal.
I think instead of "closest earlier" it would be best to say
... @var{symbol} is the symbol whose address is the nearest to
@var{address} and below it in memory ...
Other than that, SGTM, thanks.
next prev parent reply other threads:[~2022-02-22 14:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 16:17 Andrew Burgess
2022-02-11 18:54 ` Eli Zaretskii
2022-02-21 17:27 ` Andrew Burgess
2022-02-21 18:02 ` Eli Zaretskii
2022-02-22 13:56 ` Andrew Burgess
2022-02-22 14:48 ` Eli Zaretskii [this message]
2022-02-23 14:20 ` Andrew Burgess
2022-03-03 16:49 ` Andrew Burgess
2022-03-03 18:35 ` Craig Blackmore
2022-03-04 10:51 ` Andrew Burgess
2022-03-04 10:50 ` [PATCHv2] " Andrew Burgess
2022-03-04 15:22 ` Simon Marchi
2022-03-07 12:33 ` [PATCHv3] gdb/python: add gdb.format_address function Andrew Burgess
2022-03-21 17:53 ` Andrew Burgess
2022-03-21 18:23 ` Simon Marchi
2022-03-22 13:19 ` Andrew Burgess
2022-03-23 12:14 ` Simon Marchi
2022-03-23 15:30 ` Andrew Burgess
2022-03-28 21:59 ` Simon Marchi
2022-03-29 13:38 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilt7t0s1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).