Re: [PATCH] gdb/python: add gdb.Architecture.format_address

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org> writes:

>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Tue, 22 Feb 2022 13:56:17 +0000
>> 
>> So, appologies, but this is another complete rewrite of the docs.  With
>> the exception of the name, for which I still have no better suggestions,
>> how's this?
>
> Let's see...
>
>> +@defun Architecture.format_address (@var{address})
>> +Return a string in the format @samp{@var{addr}
>> +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address}
>> +formatted in hexadecimal, @var{symbol} is the closest earlier symbol
>> +to @var{address}, and @var{offset} is the offset from @var{symbol} to
>> +@var{address} in decimal.
>
> I think instead of "closest earlier" it would be best to say
>
>   ... @var{symbol} is the symbol whose address is the nearest to
>   @var{address} and below it in memory ...
>
> Other than that, SGTM, thanks.

Thanks for all your feedback.  I've made this change locally, and it
will be included once someone has reviewed the rest of the code.

Thanks,
Andrew