[PATCH] Remove "-break-insert -r" tests

[PATCH] Remove "-break-insert -r" tests

[Tom Tromey]

PR mi/14270 points out that mi-break.exp has some tests for an
unimplemented "-r" switch for "-break-insert".  This switch was never
implemented, and is not documented -- though it is mentioned in a
comment in the documentation.  This patch removes the test and the doc
comment.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=14270
---
 gdb/doc/gdb.texinfo               |  6 ---
 gdb/testsuite/gdb.mi/mi-break.exp | 70 -------------------------------
 2 files changed, 76 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 68679982919..65593965eea 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -31304,12 +31304,6 @@ addr="0x00010774",func="foo",file="recursive2.c",
 fullname="/home/foo/recursive2.c",line="11",thread-groups=["i1"],
 times="0"@}]@}
 (gdb)
-@c -break-insert -r foo.*
-@c ~int foo(int, int);
-@c ^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c,
-@c "fullname="/home/foo/recursive2.c",line="11",thread-groups=["i1"],
-@c times="0"@}
-@c (gdb)
 @end smallexample
 
 @subheading The @code{-dprintf-insert} Command
diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp
index 1c5eed3d4b0..b64fe196940 100644
--- a/gdb/testsuite/gdb.mi/mi-break.exp
+++ b/gdb/testsuite/gdb.mi/mi-break.exp
@@ -96,75 +96,6 @@ proc_with_prefix test_tbreak_creation_and_listing {} {
 	    "delete temp breakpoints"
 }
 
-proc_with_prefix test_rbreak_creation_and_listing {} {
-    global line_callee4_body
-    global line_callee3_body
-    global line_callee2_body
-    global line_callee1_body
-    global line_main_body
-
-    # Insert some breakpoints and list them
-    # Also, disable some so they do not interfere with other tests
-    # Tests:
-    # -break-insert -r main
-    # -break-insert -r callee2
-    # -break-insert -r callee
-    # -break-insert -r .*llee
-    # -break-list
-
-    setup_kfail "*-*-*" mi/14270
-    set bps {}
-    lappend bps [mi_make_breakpoint -number 5 -file ".*basics.c" \
-		     -line $line_main_body]
-    mi_gdb_test "122-break-insert -r main" \
-	"122\\^done,[lindex $bps end]" \
-	"break-insert -r operation"
-
-    setup_kfail "*-*-*" mi/14270
-    lappend bps [mi_make_breakpoint -number 6 -file ".*basics.c" \
-		     -line $line_callee2_body]
-    mi_gdb_test "133-break-insert -r callee2" \
-	"133\\^done,[lindex $bps end]" \
-	"insert breakpoint with regexp callee2"
-
-    setup_kfail "*-*-*" mi/14270
-    set start [llength $bps]
-    lappend bps [mi_make_breakpoint -number 7 -file ".*basics.c" \
-		     -line $line_callee1_body]
-    lappend bps [mi_make_breakpoint -number 8 -file ".*basics.c" \
-		     -line $line_callee2_body]
-    lappend bps [mi_make_breakpoint -number 9 -file ".*basics.c" \
-		     -line $line_callee3_body]
-    lappend bps [mi_make_breakpoint -number 10 -file ".*basics.c" \
-		     -line $line_callee4_body]
-    mi_gdb_test "144-break-insert -r callee" \
-	"144\\^done,[join [lrange $bps $start end] ,]" \
-	"insert breakpoint with regexp callee"
-
-    setup_kfail "*-*-*" mi/14270
-    set start [llength $bps]
-    lappend bps [mi_make_breakpoint -number 11 -file ".*basics.c" \
-		     -line $line_callee1_body]
-    lappend bps [mi_make_breakpoint -number 12 -file ".*basics.c" \
-		     -line $line_callee2_body]
-    lappend bps [mi_make_breakpoint -number 13 -file ".*basics.c" \
-		     -line $line_callee3_body]
-    lappend bps [mi_make_breakpoint -number 14 -file ".*basics.c" \
-		     -line $line_callee4_body]
-    mi_gdb_test "155-break-insert -r \.\*llee" \
-	"155\\^done,[join [lrange $bps $start end] ,]" \
-	"insert breakpoint with regexp .*llee"
-
-    setup_kfail "*-*-*" mi/14270
-    mi_gdb_test "166-break-list" \
-	"166\\^done,[mi_make_breakpoint_table $bps]" \
-	"list of breakpoints"
-
-    mi_gdb_test "177-break-delete" \
-	    "177\\^done" \
-	    "delete temp breakpoints"
-}
-
 proc_with_prefix test_abreak_creation {} {
     mi_create_varobj tpnum \$tpnum "create local variable tpnum"
     # Test that $tpnum is not set before creating a tracepoint.
@@ -478,7 +409,6 @@ proc test_break {mi_mode} {
     mi_gdb_load ${binfile}
 
     test_tbreak_creation_and_listing
-    test_rbreak_creation_and_listing
 
     test_ignore_count
 
-- 
2.34.1

Re: [PATCH] Remove "-break-insert -r" tests

[Eli Zaretskii]

> Date: Thu, 26 May 2022 10:19:57 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> PR mi/14270 points out that mi-break.exp has some tests for an
> unimplemented "-r" switch for "-break-insert".  This switch was never
> implemented, and is not documented -- though it is mentioned in a
> comment in the documentation.  This patch removes the test and the doc
> comment.

Thanks, the documentation part is obviously OK.

Re: [PATCH] Remove "-break-insert -r" tests

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> PR mi/14270 points out that mi-break.exp has some tests for an
Tom> unimplemented "-r" switch for "-break-insert".  This switch was never
Tom> implemented, and is not documented -- though it is mentioned in a
Tom> comment in the documentation.  This patch removes the test and the doc
Tom> comment.

Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=14270

I'm checking this in now.

Tom