From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Add check-include-guards.py to pre-commit
Date: Thu, 18 Apr 2024 09:45:08 -0600 [thread overview]
Message-ID: <871q72zncr.fsf@tromey.com> (raw)
In-Reply-To: <7c984d39-27a2-4d6e-aea7-08ffc2417cdb@simark.ca> (Simon Marchi's message of "Thu, 18 Apr 2024 11:33:01 -0400")
Simon> The regex is a bit hard to read... can you add a comment to indicate
Simon> what this indends to match? I think this does not match header files
Simon> under gdb/testsuite (because they are deeper than what the regex would
Simon> match)?
I added this:
# This matches headers in gdbsupport, gdbserver, gdb, and the
# immediate subdirectories of gdb (e.g., gdb/nat) -- but,
# importantly, not gdb/testsuite/*/*.h.
I went a little too fast sending v2, should have waited a bit.
Anyway I don't think this addition warrants a v3.
Tom
next prev parent reply other threads:[~2024-04-18 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 22:05 [PATCH 0/4] Add include guard checker and reformatter Tom Tromey
2024-04-17 22:05 ` [PATCH 1/4] Fix some minor header file irregularities Tom Tromey
2024-04-17 22:05 ` [PATCH 2/4] Add an include-checking script Tom Tromey
2024-04-18 12:54 ` Tom de Vries
2024-04-18 15:31 ` Tom Tromey
2024-04-18 15:29 ` Simon Marchi
2024-04-18 15:40 ` Tom Tromey
2024-04-18 15:42 ` Simon Marchi
2024-04-17 22:05 ` [PATCH 3/4] Add check-include-guards.py to pre-commit Tom Tromey
2024-04-18 15:33 ` Simon Marchi
2024-04-18 15:45 ` Tom Tromey [this message]
2024-04-17 22:05 ` [PATCH 4/4] Run check-include-guards.py Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q72zncr.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).