public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Add an include-checking script
Date: Thu, 18 Apr 2024 09:31:50 -0600	[thread overview]
Message-ID: <87bk66znyx.fsf@tromey.com> (raw)
In-Reply-To: <6ead9447-de50-45fd-b18b-cd68f8824f76@suse.de> (Tom de Vries's message of "Thu, 18 Apr 2024 14:54:09 +0200")

Tom> The only thing I ran into was that the corner-case of an empty file:

Thanks, I fixed this.

Also I found out that if a pre-commit hook modifies a file, pre-commit
will still DTRT (fail), so error messages aren't needed in this case.
I've updated the script to do this.

Tom

  reply	other threads:[~2024-04-18 15:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 22:05 [PATCH 0/4] Add include guard checker and reformatter Tom Tromey
2024-04-17 22:05 ` [PATCH 1/4] Fix some minor header file irregularities Tom Tromey
2024-04-17 22:05 ` [PATCH 2/4] Add an include-checking script Tom Tromey
2024-04-18 12:54   ` Tom de Vries
2024-04-18 15:31     ` Tom Tromey [this message]
2024-04-18 15:29   ` Simon Marchi
2024-04-18 15:40     ` Tom Tromey
2024-04-18 15:42       ` Simon Marchi
2024-04-17 22:05 ` [PATCH 3/4] Add check-include-guards.py to pre-commit Tom Tromey
2024-04-18 15:33   ` Simon Marchi
2024-04-18 15:45     ` Tom Tromey
2024-04-17 22:05 ` [PATCH 4/4] Run check-include-guards.py Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk66znyx.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).