From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in gdbpy_parse_register_id
Date: Sun, 21 Aug 2022 08:01:57 -0600 [thread overview]
Message-ID: <871qt9vgoa.fsf@tromey.com> (raw)
In-Reply-To: <87czff14og.fsf@tromey.com> (Tom Tromey's message of "Sat, 11 Jun 2022 11:38:23 -0600")
[...]
Tom> I did this.
Tom> New patch appended.
Tom> Fix crash in gdbpy_parse_register_id
Tom> I noticed that gdbpy_parse_register_id would assert if passed a Python
Tom> object of a type it was not expecting. The included test case shows
Tom> this crash. This patch fixes the problem and also changes
Tom> gdbpy_parse_register_id to be more "Python-like" -- it always ensures
Tom> the Python error is set when it fails, and the callers now simply
Tom> propagate the existing exception.
I'm checking this in now.
Tom
prev parent reply other threads:[~2022-08-21 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 21:27 Tom Tromey
2022-04-28 1:45 ` Simon Marchi
2022-04-28 2:11 ` Tom Tromey
2022-06-11 17:38 ` Tom Tromey
2022-08-21 14:01 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qt9vgoa.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).