From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in gdbpy_parse_register_id
Date: Wed, 27 Apr 2022 20:11:10 -0600 [thread overview]
Message-ID: <871qxi6jpd.fsf@tromey.com> (raw)
In-Reply-To: <80873420-8a71-111f-453c-f354381e0ad3@simark.ca> (Simon Marchi's message of "Wed, 27 Apr 2022 21:45:42 -0400")
>> + PyErr_SetString (PyExc_ValueError, "Bad register");
Simon> It seems like you kept the wrong line here? If this is really an error
Simon> and no test has caught this, it means we're lacking some coverage.
Geez. I will look into that.
I used to periodically do coverage analysis of gdb but lately lcov
doesn't seem to work for me and I haven't bothered to track it down.
Tom
next prev parent reply other threads:[~2022-04-28 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 21:27 Tom Tromey
2022-04-28 1:45 ` Simon Marchi
2022-04-28 2:11 ` Tom Tromey [this message]
2022-06-11 17:38 ` Tom Tromey
2022-08-21 14:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qxi6jpd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).