Re: [PATCH v5 4/8] GDB/testsuite: Tighten `set print elements' error check

[Andrew Burgess <aburgess@redhat.com>]

"Maciej W. Rozycki" <macro@embecosm.com> writes:

> Match the whole error message expected to be given rather than omitting 
> the part about the "unlimited" keyword.  There's no point in omitting 
> the missing part first, and second with an upcoming change the part in 
> parentheses will no longer be a fixed string, so doing a full match will 
> ensure the algorithm correctly builds the message expected here.  Also 
> avoid any wildcard matches.

LGTM.

Thanks,
Andrew

> ---
> No change from v4.
>
> New change in v4.
> ---
>  gdb/testsuite/gdb.base/default.exp |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> gdb-test-set-print-elements-tightening.diff
> Index: src/gdb/testsuite/gdb.base/default.exp
> ===================================================================
> --- src.orig/gdb/testsuite/gdb.base/default.exp
> +++ src/gdb/testsuite/gdb.base/default.exp
> @@ -525,7 +525,8 @@ gdb_test_no_output "set print asm-demang
>  #test set print demangle
>  gdb_test_no_output "set print demangle" "set print demangle"
>  #test set print elements
> -gdb_test "set print elements" "Argument required .integer to set it to.*"
> +gdb_test "set print elements" \
> +	 "Argument required \\(integer to set it to, or \"unlimited\"\\)\\."
>  #test set print object
>  gdb_test_no_output "set print object" "set print object"
>  #test set print pretty