Re: [PATCHv5 0/2] Disassembler Output Styling

[Andrew Burgess <aburgess@redhat.com>]

Ping!

Any objections if I merge this?

Patch #2 was already given the OK right back in V1.

Patch #1 had some general points raised in V1, which I've addressed, but
nothing serious.  So I think this is probably OK to push, but I want to
give folk a change to complain before I go for it.

Thanks,
Andrew



Andrew Burgess <aburgess@redhat.com> writes:

> Changes in v5:
>
>   Rebased onto current master.
>
>   Simplified the colorize_disasm API in match my latest proposal here:
>     https://sourceware.org/pipermail/gdb-patches/2022-January/185060.html
>   That is, the colorize_disasm takes a bytes object, and is expected
>   to return a bytes object, nothing else is allowed (ecept for None,
>   which is a special case).
>
> Changes in v4:
>
>   Rebased on to current master.  The colorize_disasm function is now
>   passed a bytes object rather than a unicode string.  The return from
>   colorize_disasm can be either a bytes object, or a unicode string.
>   If GDB gets a unicode string, then it is converted to bytes using
>   the current host_charset().
>
>   There's no change in the documentation in this version, the
>   documentation has already been reviewed in a previous version.
>
> Changes in v3:
>
>   In this update, the biggest change, is that the controlling setting is
>   now 'set/show style disassembler enabled', that is I've added
>   'enabled' to the setting name.
>   
>   My reason for this is that, in the future, I might want to add
>   additional disassembler styles, like:
>   
>     set style disassembler register ....
>     set style disassembler mnemonic ....
>   
>   And the new setting name leaves this possibility open, while the old
>   setting made this harder.
>   
>   This version also includes an improved test, minor updates to the docs
>   to match the above change, and a rebase to current master.
>
>
> ---
>
> Andrew Burgess (2):
>   gdb: use python to colorize disassembler output
>   gdb/python: move styling support to gdb.styling
>
>  gdb/NEWS                         |  6 +++
>  gdb/cli/cli-style.c              | 44 +++++++++++++++++
>  gdb/cli/cli-style.h              |  3 ++
>  gdb/data-directory/Makefile.in   |  1 +
>  gdb/disasm.c                     | 58 +++++++++++++++++++++-
>  gdb/disasm.h                     | 25 ++++++++++
>  gdb/doc/gdb.texinfo              | 15 ++++++
>  gdb/extension-priv.h             |  6 +++
>  gdb/extension.c                  | 20 ++++++++
>  gdb/extension.h                  |  8 +++
>  gdb/python/lib/gdb/__init__.py   | 18 -------
>  gdb/python/lib/gdb/styling.py    | 49 ++++++++++++++++++
>  gdb/python/python.c              | 85 ++++++++++++++++++++++++++++++--
>  gdb/testsuite/gdb.base/style.exp | 82 +++++++++++++++++++++++++++++-
>  14 files changed, 396 insertions(+), 24 deletions(-)
>  create mode 100644 gdb/python/lib/gdb/styling.py
>
> -- 
> 2.25.4