From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCHv4 2/2] gdb/python: move styling support to gdb.styling
Date: Thu, 10 Feb 2022 14:15:09 -0700 [thread overview]
Message-ID: <87v8xms9sy.fsf@tromey.com> (raw)
In-Reply-To: <e1bd3d89e14b578348072ba74e7fcfe8e99d41e2.1641911175.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 11 Jan 2022 14:31:01 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> From: Andrew Burgess <andrew.burgess@embecosm.com>
Andrew> This commit moves the two Python functions that are used for styling
Andrew> into a new module, gdb.styling, there's then a small update in
Andrew> python.c so GDB can find the functions in their new location.
Makes sense to me.
Andrew> Still, despite these functions never having been part of a documented
Andrew> API, it is possible that a user out there has overridden these to, in
Andrew> some way, customize how GDB performs styling. Moving the function as
Andrew> I propose in this patch could break things for that user, however,
Andrew> fixing this breakage is trivial, and, as these functions were never
Andrew> documented, I don't think we should be obliged to not break user code
Andrew> that relies on them.
Also, in Python it's easy to have the code dynamically adjust, because
it can examine the module and change its behavior. So this sort of
change is pretty easy to adapt to if need be.
Tom
next prev parent reply other threads:[~2022-02-10 21:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:37 [PATCH 0/4] Disassembler Output Styling Andrew Burgess
2021-10-26 9:37 ` [PATCH 1/4] gdb/python: make some global variables static Andrew Burgess
2021-10-27 20:20 ` Tom Tromey
2021-11-25 10:12 ` Andrew Burgess
2021-11-25 15:02 ` Enze Li
2021-11-25 18:11 ` Andrew Burgess
2021-10-26 9:37 ` [PATCH 2/4] gdb: rename source_styling_changed observer Andrew Burgess
2021-10-27 20:22 ` Tom Tromey
2021-11-25 10:17 ` Andrew Burgess
2021-10-26 9:37 ` [PATCH 3/4] gdb: use python to colorize disassembler output Andrew Burgess
2021-10-27 20:38 ` Tom Tromey
2021-10-28 16:28 ` Andrew Burgess
2021-11-22 14:44 ` Andrew Burgess
2021-10-26 9:37 ` [PATCH 4/4] gdb/python: move styling support to gdb.styling Andrew Burgess
2021-10-27 20:39 ` Tom Tromey
2021-11-25 10:36 ` [PATCHv2 0/2] Disassembler Output Styling Andrew Burgess
2021-11-25 10:36 ` [PATCHv2 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2021-11-25 11:04 ` Eli Zaretskii
2021-11-25 10:36 ` [PATCHv2 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2021-12-06 14:32 ` Ping: [PATCHv2 0/2] Disassembler Output Styling Andrew Burgess
2021-12-13 14:12 ` [PATCHv3 " Andrew Burgess
2021-12-13 14:12 ` [PATCHv3 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2021-12-13 14:12 ` [PATCHv3 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-01-11 14:30 ` [PATCHv4 0/2] Disassembler Output Styling Andrew Burgess
2022-01-11 14:31 ` [PATCHv4 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2022-02-10 21:13 ` Tom Tromey
2022-02-11 14:27 ` Andrew Burgess
2022-02-13 18:02 ` Tom Tromey
2022-02-14 11:22 ` Andrew Burgess
2022-01-11 14:31 ` [PATCHv4 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-02-10 21:15 ` Tom Tromey [this message]
2022-02-10 21:16 ` Tom Tromey
2022-01-21 16:26 ` [PATCHv5 0/2] Disassembler Output Styling Andrew Burgess
2022-01-21 16:26 ` [PATCHv5 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2022-01-21 16:26 ` [PATCHv5 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-02-03 20:32 ` [PATCHv5 0/2] Disassembler Output Styling Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8xms9sy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).