public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCHv4 0/2] Disassembler Output Styling
Date: Tue, 11 Jan 2022 14:30:59 +0000	[thread overview]
Message-ID: <cover.1641911175.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1639404422.git.aburgess@redhat.com>

Changes in v4:

  Rebased on to current master.  The colorize_disasm function is now
  passed a bytes object rather than a unicode string.  The return from
  colorize_disasm can be either a bytes object, or a unicode string.
  If GDB gets a unicode string, then it is converted to bytes using
  the current host_charset().

  There's no change in the documentation in this version, the
  documentation has already been reviewed in a previous version.

Changes in v3:

  In this update, the biggest change, is that the controlling setting is
  now 'set/show style disassembler enabled', that is I've added
  'enabled' to the setting name.
  
  My reason for this is that, in the future, I might want to add
  additional disassembler styles, like:
  
    set style disassembler register ....
    set style disassembler mnemonic ....
  
  And the new setting name leaves this possibility open, while the old
  setting made this harder.
  
  This version also includes an improved test, minor updates to the docs
  to match the above change, and a rebase to current master.

---

Andrew Burgess (2):
  gdb: use python to colorize disassembler output
  gdb/python: move styling support to gdb.styling

 gdb/NEWS                         |  6 ++
 gdb/cli/cli-style.c              | 44 ++++++++++++++
 gdb/cli/cli-style.h              |  3 +
 gdb/data-directory/Makefile.in   |  1 +
 gdb/disasm.c                     | 58 ++++++++++++++++++-
 gdb/disasm.h                     | 25 ++++++++
 gdb/doc/gdb.texinfo              | 15 +++++
 gdb/extension-priv.h             |  6 ++
 gdb/extension.c                  | 20 +++++++
 gdb/extension.h                  |  8 +++
 gdb/python/lib/gdb/__init__.py   | 18 ------
 gdb/python/lib/gdb/styling.py    | 49 ++++++++++++++++
 gdb/python/python.c              | 98 +++++++++++++++++++++++++++++++-
 gdb/testsuite/gdb.base/style.exp | 82 +++++++++++++++++++++++++-
 14 files changed, 409 insertions(+), 24 deletions(-)
 create mode 100644 gdb/python/lib/gdb/styling.py

-- 
2.25.4


  parent reply	other threads:[~2022-01-11 14:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  9:37 [PATCH 0/4] " Andrew Burgess
2021-10-26  9:37 ` [PATCH 1/4] gdb/python: make some global variables static Andrew Burgess
2021-10-27 20:20   ` Tom Tromey
2021-11-25 10:12     ` Andrew Burgess
2021-11-25 15:02       ` Enze Li
2021-11-25 18:11         ` Andrew Burgess
2021-10-26  9:37 ` [PATCH 2/4] gdb: rename source_styling_changed observer Andrew Burgess
2021-10-27 20:22   ` Tom Tromey
2021-11-25 10:17     ` Andrew Burgess
2021-10-26  9:37 ` [PATCH 3/4] gdb: use python to colorize disassembler output Andrew Burgess
2021-10-27 20:38   ` Tom Tromey
2021-10-28 16:28     ` Andrew Burgess
2021-11-22 14:44       ` Andrew Burgess
2021-10-26  9:37 ` [PATCH 4/4] gdb/python: move styling support to gdb.styling Andrew Burgess
2021-10-27 20:39   ` Tom Tromey
2021-11-25 10:36 ` [PATCHv2 0/2] Disassembler Output Styling Andrew Burgess
2021-11-25 10:36   ` [PATCHv2 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2021-11-25 11:04     ` Eli Zaretskii
2021-11-25 10:36   ` [PATCHv2 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2021-12-06 14:32   ` Ping: [PATCHv2 0/2] Disassembler Output Styling Andrew Burgess
2021-12-13 14:12   ` [PATCHv3 " Andrew Burgess
2021-12-13 14:12     ` [PATCHv3 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2021-12-13 14:12     ` [PATCHv3 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-01-11 14:30     ` Andrew Burgess [this message]
2022-01-11 14:31       ` [PATCHv4 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2022-02-10 21:13         ` Tom Tromey
2022-02-11 14:27           ` Andrew Burgess
2022-02-13 18:02             ` Tom Tromey
2022-02-14 11:22               ` Andrew Burgess
2022-01-11 14:31       ` [PATCHv4 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-02-10 21:15         ` Tom Tromey
2022-02-10 21:16         ` Tom Tromey
2022-01-21 16:26       ` [PATCHv5 0/2] Disassembler Output Styling Andrew Burgess
2022-01-21 16:26         ` [PATCHv5 1/2] gdb: use python to colorize disassembler output Andrew Burgess
2022-01-21 16:26         ` [PATCHv5 2/2] gdb/python: move styling support to gdb.styling Andrew Burgess
2022-02-03 20:32         ` [PATCHv5 0/2] Disassembler Output Styling Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1641911175.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).