Re: [PATCH v3 3/5] [dap & linetable]: Change gdb.LineTableEntry & Add gdb.lookup_linetable

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Farre <simon.farre.cx@gmail.com> writes:

Thanks for the patch.

Simon>  static PyObject *
Simon> -build_line_table_tuple_from_pcs (int line, const std::vector<CORE_ADDR> &pcs)
Simon> +build_line_table_tuple_from_pcs (int line, const symtab& sym, const std::vector<linetable_entry> &pcs)

gdb uses a line length around 80, so this should be split.
Also the "&" attaches to the "sym", not "symtab" -- this is also true
for "*" in gdb, there's a few instances of this around.

Simon> +/* Search for a symtab whose fullname contains FILENAME and return it's
Simon> +   linetable.  */
Simon> +PyObject *
Simon> +gdbpy_lookup_linetable_by_filename (PyObject *, PyObject *args, PyObject *kw)
Simon> +{
Simon> +  const char *arg = nullptr;
Simon> +  static const char *keywords[] = { "filename", nullptr };
Simon> +
Simon> +  if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "s", keywords, &arg))
Simon> +    {
Simon> +      return nullptr;
Simon> +    }

Don't need the braces here.

Simon> +
Simon> +  for (objfile *objfile : current_program_space->objfiles ())
Simon> +    for (compunit_symtab *cu : objfile->compunits ())
Simon> +      for (symtab *s : cu->filetabs ())
Simon> +	{
Simon> +	  const auto name = symtab_to_fullname (s);
Simon> +
Simon> +	  if (strstr (name, arg))

This doesn't seem like a great approach to me.
Substring matching isn't how this kind of thing works elsewhere in gdb.

Also this looping approach means that the symtab must somehow have
already been expanded.

Right now, the breakpointLocations request works by calling MI's
-symbol-list-lines.  This calls lookup_symtab, which in the end will try
expanding CUs to find the desired symtab.

Tom