Re: [PATCH v3 1/5] [dap & linetable]: Add column to linetable entry

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Farre <simon.farre.cx@gmail.com> writes:

Thanks for the patch.

Simon>  void
Simon> -record_line (struct subfile *subfile, int line, unrelocated_addr pc)
Simon> +record_line (struct subfile *subfile, int line, uint col, unrelocated_addr pc)

"uint" isn't really a type used in gdb.  I think "unsigned" would be
fine.

 
Simon> +  void set_column (unsigned int column) noexcept {
Simon> +    m_col = column;
Simon> +  }

gdb style puts the opening brace on the next line.

Simon> +  else if(line == last_line && col != last_col)
Simon> +    return 1;

Space before paren.

Simon> diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c
Simon> index 73df0ed8165..b5cbe4548a7 100644
Simon> --- a/gdb/mdebugread.c
Simon> +++ b/gdb/mdebugread.c
Simon> @@ -4008,7 +4008,7 @@ mdebug_expand_psymtab (legacy_psymtab *pst, struct objfile *objfile)
Simon>  		{
Simon>  		  /* Handle encoded stab line number.  */
Simon>  		  record_line
Simon> -		    (get_current_subfile (), sh.index,
Simon> +		    (get_current_subfile (), sh.index, 0,

Unfortunately there's also mdebugread.c:add_line.
I suspect this code is already a bit wrong because new_linetable doesn't
zero out the memory.

I think there are other such spots needing an update as well, for
instance jit.c.

Simon> -  /* Two entries are equal if they have the same line and PC.  The
Simon> +  /* Two entries are equal if they have the same line, PC and col.  The
Simon>       other members are ignored.  */
Simon>    bool operator== (const linetable_entry &other) const
Simon> -  { return line == other.line && m_pc == other.m_pc; }
Simon> +  { return line == other.line && m_pc == other.m_pc && col == other.col; }

Does operator< also need a change?

Tom