From: Tom Tromey <tom@tromey.com>
To: Simon Farre <simon.farre.cx@gmail.com>
Cc: gdb-patches@sourceware.org, tom@tromey.org
Subject: Re: [PATCH v3 4/5] [dap & linetable]: Add breakpointLocations request
Date: Wed, 07 Feb 2024 12:44:56 -0700 [thread overview]
Message-ID: <87bk8sawjr.fsf@tromey.com> (raw)
In-Reply-To: <20240122133115.201205-4-simon.farre.cx@gmail.com> (Simon Farre's message of "Mon, 22 Jan 2024 14:31:14 +0100")
>>>>> "Simon" == Simon Farre <simon.farre.cx@gmail.com> writes:
Simon> Testing might strictly not be possible for this feature. Users are going
Simon> to have wildly varying compilers and compiler versions that outputs
Simon> wildly different debug symbol information. So unless we can restrain the
Simon> tests to some specific toolchain that I can handroll the tests for, this
Simon> will not be useful (and handrolling for a specific compiler defeats the
Simon> purpose - as one can just use the eyes then to verify).
It may be possible to write a custom test case using the "DWARF
assembler".
Simon> +@request("breakpointLocations")
Simon> +@capability("supportsBreakpointLocationsRequest")
This already exists in locations.py.
I'll send a patch to make sure that double-registration is impossible.
Tom
next prev parent reply other threads:[~2024-02-07 19:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 13:31 [PATCH v3 1/5] [dap & linetable]: Add column to linetable entry Simon Farre
2024-01-22 13:31 ` [PATCH v3 2/5] [dap & linetable]: Add column to maint info linetable output Simon Farre
2024-02-07 19:52 ` Tom Tromey
2024-01-22 13:31 ` [PATCH v3 3/5] [dap & linetable]: Change gdb.LineTableEntry & Add gdb.lookup_linetable Simon Farre
2024-02-07 20:05 ` Tom Tromey
2024-01-22 13:31 ` [PATCH v3 4/5] [dap & linetable]: Add breakpointLocations request Simon Farre
2024-02-07 19:44 ` Tom Tromey [this message]
2024-01-22 13:31 ` [PATCH v3 5/5] [dap & linetable]: Added docs Simon Farre
2024-02-07 19:28 ` [PATCH v3 1/5] [dap & linetable]: Add column to linetable entry Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk8sawjr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
--cc=tom@tromey.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).