Re: [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang

[Tom Tromey <tom@tromey.com>]

>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

Bruno> It also adds a new parameter to get_hexadecimal_valueof, so that we can
Bruno> use it without generating new passes, otherwise we'd get multiple
Bruno> duplicate test names. This change shouldn't affect any other test using
Bruno> this proc.

You can just pass different test names instead.

Bruno> +proc get_current_pc {} {
Bruno> +    set pc 0
Bruno> +    gdb_test_multiple "print \$pc" "" {
Bruno> +	-re -wrap ".*0x(\[0-9a-f\]+).*" {
Bruno> +	    set pc $expect_out(1,string)
Bruno> +	}
Bruno> +    }
Bruno> +    return $pc

It seems to me that this shouldn't be needed.

Bruno> diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp
Bruno> index 4b78a8f8fb7..9ff97bfde42 100644
Bruno> --- a/gdb/testsuite/gdb.reverse/step-reverse.exp
Bruno> +++ b/gdb/testsuite/gdb.reverse/step-reverse.exp
Bruno> @@ -28,6 +28,16 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
Bruno>      return -1
Bruno>  }
 
Bruno> +proc get_current_pc {} {
Bruno> +    set pc 0
Bruno> +    gdb_test_multiple "print \$pc" "" {
Bruno> +	-re -wrap ".*0x(\[0-9a-f\]+).*" {
Bruno> +	    set pc $expect_out(1,string)
Bruno> +	}
Bruno> +    }
Bruno> +    return $pc

Same with this one.

Tom