From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang
Date: Wed, 26 Jul 2023 07:37:39 -0600 [thread overview]
Message-ID: <87wmymkd3w.fsf@tromey.com> (raw)
In-Reply-To: <20230725095833.236804-3-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Tue, 25 Jul 2023 11:58:31 +0200")
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
Bruno> diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.c b/gdb/testsuite/gdb.reverse/solib-reverse.c
Bruno> index 7aa60089df3..f8c98f2ab94 100644
Bruno> --- a/gdb/testsuite/gdb.reverse/solib-reverse.c
Bruno> +++ b/gdb/testsuite/gdb.reverse/solib-reverse.c
Bruno> @@ -43,6 +43,7 @@ int main ()
Bruno> shr1 ("message 2\n"); /* shr1 two */
Bruno> shr1 ("message 3\n"); /* shr1 three */
Bruno> - return 0; /* end part one */
Bruno> -} /* end of main */
Bruno> + asm("nop"); /* end part one */
Bruno> + return 0; /* end of main */
I suspect it would be better to use something other than 'asm' here,
like an assignment to some global or something like that.
Tom
next prev parent reply other threads:[~2023-07-26 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 9:58 [PATCH 0/4] Many fixes to gdb.reverse tests Bruno Larsen
2023-07-25 9:58 ` [PATCH 1/4] gdb/testsuite: Fix many errors in gdb.reverse with clang Bruno Larsen
2023-07-25 9:58 ` [PATCH 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang Bruno Larsen
2023-07-26 13:37 ` Tom Tromey [this message]
2023-07-25 9:58 ` [PATCH 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang Bruno Larsen
2023-07-26 13:39 ` Tom Tromey
2023-07-25 9:58 ` [PATCH 4/4] gdb/testsuite: Multiple improvements for gdb.reverse/insn-reverse.exp Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 0/4] Many fixes to gdb.reverse tests Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 1/4] gdb/testsuite: Fix many errors in gdb.reverse with clang Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang Bruno Larsen
2023-07-28 13:14 ` Tom Tromey
2023-07-28 13:20 ` Bruno Larsen
2023-07-28 14:18 ` Tom Tromey
2023-07-28 14:20 ` Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 4/4] gdb/testsuite: Multiple improvements for gdb.reverse/insn-reverse.exp Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmymkd3w.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).