From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang
Date: Fri, 28 Jul 2023 16:20:47 +0200 [thread overview]
Message-ID: <f37eeb30-cb44-c153-6b74-443ba738c214@redhat.com> (raw)
In-Reply-To: <87tttoglv3.fsf@tromey.com>
On 28/07/2023 16:18, Tom Tromey wrote:
>>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> Bruno> I mean, yeah I can, but since it is in a loop, the differences would
> Bruno> only be a counter at the end of the test case. Are we really getting
> Bruno> any value from that? To me it seems like it would just boggle down the
> Bruno> sum file with meaningless "tests" that aren't exercising any relevant
> Bruno> code paths. I can do it if you disagree, though, it isn't a big deal.
>
> Yeah, I don't know if it's useful -- but are any of these passes useful?
> The problem I think is that the proc can unconditionally emit a fail, so
> having a corresponding pass seems to make sense.
>
Ah, yeah, in that angle it does make sense. I'll do it for v3!
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-07-28 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 9:58 [PATCH 0/4] Many fixes to gdb.reverse tests Bruno Larsen
2023-07-25 9:58 ` [PATCH 1/4] gdb/testsuite: Fix many errors in gdb.reverse with clang Bruno Larsen
2023-07-25 9:58 ` [PATCH 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang Bruno Larsen
2023-07-26 13:37 ` Tom Tromey
2023-07-25 9:58 ` [PATCH 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang Bruno Larsen
2023-07-26 13:39 ` Tom Tromey
2023-07-25 9:58 ` [PATCH 4/4] gdb/testsuite: Multiple improvements for gdb.reverse/insn-reverse.exp Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 0/4] Many fixes to gdb.reverse tests Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 1/4] gdb/testsuite: Fix many errors in gdb.reverse with clang Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 2/4] gdb/testsuite: fix gdb.reverse/solib-*.exp tests when using clang Bruno Larsen
2023-07-27 7:41 ` [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang Bruno Larsen
2023-07-28 13:14 ` Tom Tromey
2023-07-28 13:20 ` Bruno Larsen
2023-07-28 14:18 ` Tom Tromey
2023-07-28 14:20 ` Bruno Larsen [this message]
2023-07-27 7:41 ` [PATCH v2 4/4] gdb/testsuite: Multiple improvements for gdb.reverse/insn-reverse.exp Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f37eeb30-cb44-c153-6b74-443ba738c214@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).