From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 5/5] gdb: fix reread_symbols when an objfile has target: prefix
Date: Mon, 02 Oct 2023 11:00:17 -0600 [thread overview]
Message-ID: <874jj90xjy.fsf@tromey.com> (raw)
In-Reply-To: <87fs2txb4y.fsf@redhat.com> (Andrew Burgess's message of "Mon, 02 Oct 2023 17:05:49 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> We know that the value in reread_symbols comes from the system stat. So
Andrew> what I'm missing, is the path by which objfile::mtime gets set from
Andrew> anywhere other that within libbfd.a, such that it might get contaminated
Andrew> by a gnulib stat result.
I was digging some more and I found:
commit d706b69e48268ccf3e95fd29b5374ac94c3a507b
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Sep 8 10:20:44 2020 -0600
Do not adjust mtime timezone on Windows
... where I put in a patch to disable gnulib's stat replacement.
So I think your patch is totally fine, and I don't really know why I
didn't land my other changes after this.
Tom
next prev parent reply other threads:[~2023-10-02 17:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 14:22 [PATCH 0/5] Fix using an exec file with " Andrew Burgess
2023-09-27 14:22 ` [PATCH 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-27 14:22 ` [PATCH 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-27 14:22 ` [PATCH 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-27 14:22 ` [PATCH 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 12:06 ` Andrew Burgess
2023-09-27 14:22 ` [PATCH 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 0/5] Fix using an exec file with " Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 18:17 ` Tom Tromey
2023-09-29 10:20 ` Andrew Burgess
2023-10-02 14:19 ` Tom Tromey
2023-10-02 16:05 ` Andrew Burgess
2023-10-02 17:00 ` Tom Tromey [this message]
2023-10-02 19:13 ` [PATCHv2 0/5] Fix using an exec file with " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jj90xjy.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).