public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 0/5] Fix using an exec file with target: prefix
Date: Wed, 27 Sep 2023 15:22:00 +0100	[thread overview]
Message-ID: <cover.1695824275.git.aburgess@redhat.com> (raw)

I spotted that if a user specifies an executable with a target:
prefix, e.g.:

  (gdb) file target:/path/to/exec

Then GDB _almost_ does what we'd want.  This is definitely suppsosed
to work as there's some code in place to support this .... but there's
also a bug.  Patch #5 fixes this issue.

Patches #1 to #4 are various bits of cleanup and refactoring that fell
out while I was working on patch #5.

---

Andrew Burgess (5):
  gdb: some additional filename styling
  gdb: use archive name in warning when appropriate
  gdb: remove use of a static buffer for building error strings
  gdb: remove print_sys_errmsg
  gdb: fix reread_symbols when an objfile has target: prefix

 gdb/inflow.c                                  |   3 +-
 gdb/main.c                                    |   7 +-
 gdb/procfs.c                                  |  32 ++--
 gdb/source.c                                  |  18 +-
 gdb/symfile.c                                 |  30 ++-
 gdb/target.c                                  |  15 ++
 gdb/target.h                                  |  39 ++++
 gdb/testsuite/gdb.server/target-exec-file.c   |  22 +++
 gdb/testsuite/gdb.server/target-exec-file.exp | 174 ++++++++++++++++++
 gdb/utils.c                                   |   9 +-
 gdb/utils.h                                   |   8 +-
 gdb/windows-nat.c                             |   2 +-
 12 files changed, 313 insertions(+), 46 deletions(-)
 create mode 100644 gdb/testsuite/gdb.server/target-exec-file.c
 create mode 100644 gdb/testsuite/gdb.server/target-exec-file.exp


base-commit: f586e3409b752748bf213520c2dbb0b44e0005d8
-- 
2.25.4


             reply	other threads:[~2023-09-27 14:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 14:22 Andrew Burgess [this message]
2023-09-27 14:22 ` [PATCH 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-27 14:22 ` [PATCH 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-27 14:22 ` [PATCH 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-27 14:22 ` [PATCH 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 12:06   ` Andrew Burgess
2023-09-27 14:22 ` [PATCH 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 0/5] Fix using an exec file with " Andrew Burgess
2023-09-28 14:00   ` [PATCHv2 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-28 14:00   ` [PATCHv2 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-28 14:00   ` [PATCHv2 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-28 14:00   ` [PATCHv2 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 14:00   ` [PATCHv2 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 18:17     ` Tom Tromey
2023-09-29 10:20       ` Andrew Burgess
2023-10-02 14:19         ` Tom Tromey
2023-10-02 16:05           ` Andrew Burgess
2023-10-02 17:00             ` Tom Tromey
2023-10-02 19:13   ` [PATCHv2 0/5] Fix using an exec file with " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1695824275.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).