* [PATCH] Move val_prettyformat to valprint.h
@ 2023-09-05 18:36 Tom Tromey
2023-09-18 18:21 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-09-05 18:36 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I stumbled across an ancient FIXME comment that was easy to fix --
val_prettyformat does not need to be in defs.h, and is easily moved to
valprint.h, where (despite what the comment says) it belongs.
Tested by rebuilding.
---
gdb/defs.h | 14 --------------
gdb/valprint.h | 11 +++++++++++
2 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/gdb/defs.h b/gdb/defs.h
index 454475b203c..f5af3e617c4 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -410,20 +410,6 @@ enum info_proc_what
extern unsigned input_radix;
extern unsigned output_radix;
-/* * Possibilities for prettyformat parameters to routines which print
- things. Like enum language, this should be in value.h, but needs
- to be here for the same reason. FIXME: If we can eliminate this
- as an arg to LA_VAL_PRINT, then we can probably move it back to
- value.h. */
-
-enum val_prettyformat
- {
- Val_no_prettyformat = 0,
- Val_prettyformat,
- /* * Use the default setting which the user has specified. */
- Val_prettyformat_default
- };
-
/* * Optional native machine support. Non-native (and possibly pure
multi-arch) targets do not need a "nm.h" file. This will be a
symlink to one of the nm-*.h files, built by the `configure'
diff --git a/gdb/valprint.h b/gdb/valprint.h
index cf5e2f210e4..0a8878055d7 100644
--- a/gdb/valprint.h
+++ b/gdb/valprint.h
@@ -22,6 +22,17 @@
#include "cli/cli-option.h"
+/* Possibilities for prettyformat parameters to routines which print
+ things. */
+
+enum val_prettyformat
+ {
+ Val_no_prettyformat = 0,
+ Val_prettyformat,
+ /* * Use the default setting which the user has specified. */
+ Val_prettyformat_default
+ };
+
/* This is used to pass formatting options to various value-printing
functions. */
struct value_print_options
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Move val_prettyformat to valprint.h
2023-09-05 18:36 [PATCH] Move val_prettyformat to valprint.h Tom Tromey
@ 2023-09-18 18:21 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-09-18 18:21 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> I stumbled across an ancient FIXME comment that was easy to fix --
Tom> val_prettyformat does not need to be in defs.h, and is easily moved to
Tom> valprint.h, where (despite what the comment says) it belongs.
Tom> Tested by rebuilding.
I'm checking this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-18 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-05 18:36 [PATCH] Move val_prettyformat to valprint.h Tom Tromey
2023-09-18 18:21 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).