From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 1/3] gdb: add gdb::make_unique function
Date: Mon, 14 Aug 2023 09:38:29 -0600 [thread overview]
Message-ID: <874jl11vnu.fsf@tromey.com> (raw)
In-Reply-To: <a0ff6c73f21eb6d9c5da31ba8a17ac58d4315a02.1692019711.git.aburgess@redhat.com> (Andrew Burgess's message of "Mon, 14 Aug 2023 14:42:32 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> While GDB is still C++11, lets add a gdb::make_unique template
Andrew> function that can be used to create std::unique_ptr objects, just like
Andrew> the C++14 std::make_unique.
Andrew> When we move to C++14 we can either alias gdb::make_unique to
Andrew> std::make_unique, or just replace the 'gdb::' prefix throughout.
This looks totally fine to me, but I wonder if this is a situation where
we'd want to use the standard make_unique when it is available, like we
do for some other things.
Tom
next prev parent reply other threads:[~2023-08-14 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 13:42 [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use Andrew Burgess
2023-08-14 13:42 ` [PATCH 1/3] gdb: add gdb::make_unique function Andrew Burgess
2023-08-14 15:38 ` Tom Tromey [this message]
2023-08-17 10:26 ` Andrew Burgess
2023-08-17 18:07 ` Tom Tromey
2023-08-21 10:02 ` Andrew Burgess
2023-08-14 13:42 ` [PATCH 2/3] gdb: have mi_out_new return std::unique_ptr Andrew Burgess
2023-08-14 13:42 ` [PATCH 3/3] gdb: remove mi_parse::make functions Andrew Burgess
2023-08-22 15:33 ` [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use Tom Tromey
2023-08-23 8:52 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jl11vnu.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).