From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use
Date: Tue, 22 Aug 2023 09:33:59 -0600 [thread overview]
Message-ID: <87fs4bw0pk.fsf@tromey.com> (raw)
In-Reply-To: <cover.1692019711.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 14 Aug 2023 14:42:31 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> This started while working on another series, in order to avoid
Andrew> calling 'new' directly, I really wanted a std::make_unique function --
Andrew> but that's C++14, so not available for GDB right now.
Andrew> So I added a gdb::make_unique, which should be equivalent to the C++14
Andrew> function.
Andrew> The last two commits are additional make_unique/unique_ptr changes,
Andrew> but target specific areas that needed slightly more refactoring.
Thanks for doing this. I re-read the series & with your latest
make_unique patch, it looks good to me.
FWIW I think the ::make approach was just a sort of minimal refactoring
at the time. Previously the constructor didn't do anything.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-08-22 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 13:42 Andrew Burgess
2023-08-14 13:42 ` [PATCH 1/3] gdb: add gdb::make_unique function Andrew Burgess
2023-08-14 15:38 ` Tom Tromey
2023-08-17 10:26 ` Andrew Burgess
2023-08-17 18:07 ` Tom Tromey
2023-08-21 10:02 ` Andrew Burgess
2023-08-14 13:42 ` [PATCH 2/3] gdb: have mi_out_new return std::unique_ptr Andrew Burgess
2023-08-14 13:42 ` [PATCH 3/3] gdb: remove mi_parse::make functions Andrew Burgess
2023-08-22 15:33 ` Tom Tromey [this message]
2023-08-23 8:52 ` [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs4bw0pk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).