From: Tom Tromey <tom@tromey.com>
To: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Enze Li <enze.li@hotmail.com>,
enze.li@gmx.com
Subject: Re: [PATCH] gdb/testsuite: add untested message to skip_debuginfod_tests
Date: Wed, 14 Dec 2022 10:19:30 -0700 [thread overview]
Message-ID: <874jtxewd9.fsf@tromey.com> (raw)
In-Reply-To: <OS3P286MB215237C8F85BDA1F8B652296F0E09@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (Enze Li via Gdb-patches's message of "Wed, 14 Dec 2022 15:43:24 +0800")
>>>>> "Enze" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
Enze> Hmmm...Not many. Actually, from the skip_debuginfod_tests, I see an
Enze> untested message "cannot find curl". It provides detailed information
Enze> when running the testcase. Then I thought other spots in the same
Enze> procedure may benifit from it.
Personally I think these predicates should just return the result. If
a message would be helpful, they can use 'verbose'.
Enze> If the way of my previous patch is unconventional, how about this?
I think it's kind of overkill. "verbose" in the proc would work just as
well, and I suppose my feeling (unsupported by fact really) is that
normally an "untested" is just ignored anyway, and if you want to find
out what's happening you would have to dig a bit anyway.
Also I question if "untested" is correct due to what the dejagnu manual
says:
UNTESTED
A test was not run. This is a placeholder used when there is no
real test case yet.
I think "unsupported" is what we ought to be using.
If you want to see how I think it should generally work, look at my
branch "rewrite-require". This changes "require" to be simpler and then
tests can express their static requirements very simply:
require dwarf2 !isnative mumble bleah
Then the main difficulty is converting all the code to use this.
I made a stab at it there.
Tom
prev parent reply other threads:[~2022-12-14 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 11:56 Enze Li
2022-12-12 12:44 ` Bruno Larsen
2022-12-13 16:14 ` Tom Tromey
2022-12-14 7:43 ` Enze Li
2022-12-14 17:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jtxewd9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=enze.li@gmx.com \
--cc=enze.li@hotmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).