Re: [PATCH] gdb/testsuite: add untested message to skip_debuginfod_tests

[Bruno Larsen <blarsen@redhat.com>]

On 09/12/2022 12:56, Enze Li via Gdb-patches wrote:
> When running the fetch_src_and_symbols.exp, I see the following output
> which looks weird.  I even don't know whether the execution was successful.
> ======
> Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp ...
> testcase /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
> completed in 0 seconds
>
>                  === gdb Summary ===
>
> ======
>
> It is the fact that there's not enough feedback provided during the
> skip_debuginfod_tests procedure.  Fix this by adding some untested
> messages to the skip_debuginfod_tests procedure to clarify the output.
>
> With this patch applied, I get:
> ======
> Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp ...
> UNTESTED: gdb.debuginfod/fetch_src_and_symbols.exp: cannot find debuginfo
> testcase /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
> completed in 0 seconds
>
>                  === gdb Summary ===
>
>   # of untested testcases         1
> ======
>
> I also modernized the form of 'if' with 'if {} {}' in
> skip_debuginfod_tests.

Good catch!

Reviewed-By: Bruno Larsen <blarsen@redhat.com>

-- 
Cheers,
Bruno

> Tested on x86_64-linux.
> ---
>   gdb/testsuite/lib/debuginfod-support.exp | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp
> index ceecf9071110..c1a2bb900dce 100644
> --- a/gdb/testsuite/lib/debuginfod-support.exp
> +++ b/gdb/testsuite/lib/debuginfod-support.exp
> @@ -18,11 +18,13 @@
>   # Return true if the debuginfod tests should be skipped, otherwise, return
>   # false.
>   proc skip_debuginfod_tests {} {
> -    if [is_remote host] {
> +    if { [is_remote host] } {
> +	untested "does not work on remote host"
>   	return true
>       }
>   
>       if { [which debuginfod] == 0 } {
> +	untested "cannot find debuginfo"
>   	return true
>       }
>   
> @@ -39,6 +41,7 @@ proc skip_debuginfod_tests {} {
>       if { [string first "with-debuginfod" \
>   	      [eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \
>   		   --configuration]] == -1 } {
> +	untested "GDB was not configured with debuginfod"
>   	return true
>       }
>   
>
> base-commit: cd3866b6d07b37258eb840443537baa163877e24