* [PATCH] gdb: testsuite: fix failed testcases in gdb.base/gdb-caching-proc.exp
@ 2022-03-02 8:58 Tiezhu Yang
2022-03-02 12:34 ` Andrew Burgess
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2022-03-02 8:58 UTC (permalink / raw)
To: gdb-patches
When execute the following command:
make check-gdb TESTS="gdb.base/gdb-caching-proc.exp"
we can see there exists some failed testcases:
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 1: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 2: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 3: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 4: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 5: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 6: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 7: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 8: can spawn for attach (got interactive prompt)
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 9: can spawn for attach (got interactive prompt)
here are the detailed messages in gdb/testsuite/gdb.log:
attach 873776^M
A program is being debugged already. Kill it? (y or n) n^M
Not killed.^M
(gdb) FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)
so handle the case "A program is being debugged already. Kill it" in
can_spawn_for_attach to fix the failed testcases.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
gdb/testsuite/lib/gdb.exp | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 848cd08..a35d08a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5130,6 +5130,10 @@ gdb_caching_proc can_spawn_for_attach {
kill_wait_spawned_process $test_spawn_id
return 1
}
+ -re "A program is being debugged already. Kill it. .y or n. " {
+ send_gdb "y\n"
+ exp_continue
+ }
}
kill_wait_spawned_process $test_spawn_id
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb: testsuite: fix failed testcases in gdb.base/gdb-caching-proc.exp
2022-03-02 8:58 [PATCH] gdb: testsuite: fix failed testcases in gdb.base/gdb-caching-proc.exp Tiezhu Yang
@ 2022-03-02 12:34 ` Andrew Burgess
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Burgess @ 2022-03-02 12:34 UTC (permalink / raw)
To: Tiezhu Yang, gdb-patches
Tiezhu Yang <yangtiezhu@loongson.cn> writes:
> When execute the following command:
>
> make check-gdb TESTS="gdb.base/gdb-caching-proc.exp"
>
> we can see there exists some failed testcases:
>
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 1: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 2: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 3: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 4: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 5: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 6: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 7: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 8: can spawn for attach (got interactive prompt)
> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 9: can spawn for attach (got interactive prompt)
>
> here are the detailed messages in gdb/testsuite/gdb.log:
>
> attach 873776^M
> A program is being debugged already. Kill it? (y or n) n^M
> Not killed.^M
> (gdb) FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)
>
> so handle the case "A program is being debugged already. Kill it" in
> can_spawn_for_attach to fix the failed testcases.
LGTM.
Thanks for fixing this.
Andrew
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> gdb/testsuite/lib/gdb.exp | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 848cd08..a35d08a 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5130,6 +5130,10 @@ gdb_caching_proc can_spawn_for_attach {
> kill_wait_spawned_process $test_spawn_id
> return 1
> }
> + -re "A program is being debugged already. Kill it. .y or n. " {
> + send_gdb "y\n"
> + exp_continue
> + }
> }
>
> kill_wait_spawned_process $test_spawn_id
> --
> 2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-02 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 8:58 [PATCH] gdb: testsuite: fix failed testcases in gdb.base/gdb-caching-proc.exp Tiezhu Yang
2022-03-02 12:34 ` Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).