From: Tom Tromey <tromey@adacore.com>
To: Matt Rice <ratmice@gmail.com>
Cc: Tom Tromey <tromey@adacore.com>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] Implement gdb.execute_mi
Date: Fri, 19 May 2023 09:57:06 -0600 [thread overview]
Message-ID: <875y8oz54d.fsf@tromey.com> (raw)
In-Reply-To: <CACTLOFrwv863Bfp9DHQ+=oiuAuCNBmpzGtPAZXLMuczwae34Lg@mail.gmail.com> (Matt Rice's message of "Thu, 18 May 2023 20:34:21 +0000")
Matt> I don't have much preference either way, but it brought to mind that
Matt> there are issues with kwargs,
Matt> with dict keys containing hyphens. If this were a problem though, it
Matt> would also apply to other hyphenated
Matt> command names, like 'break-insert' regardless of the initial hyphen.
Matt> I suppose that people trying to map mi commands to kwargs
Matt> would perhaps just have to mangle mi commands...
Yeah. I don't think this is a huge issue, and I do agree with Eli that
the "-" will cause less confusion when going from the MI docs to writing
code.
Also it seems to me that the most likely mapping would be the other way
-- like, trying to implement "gdb.mi.command" as a function that wraps
the MI "-command". Here you'd want to change Python style to MI style.
I did consider doing this but it seemed fine to keep it simple.
Tom
next prev parent reply other threads:[~2023-05-19 15:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:08 [PATCH 0/9] Implement the DAP "loadedSources" request Tom Tromey
2023-04-04 17:08 ` [PATCH 1/9] Use field_signed from Python MI commands Tom Tromey
2023-04-04 17:08 ` [PATCH 2/9] Use member initializers in mi_parse Tom Tromey
2023-04-04 17:08 ` [PATCH 3/9] Use accessor for mi_parse::args Tom Tromey
2023-04-04 17:08 ` [PATCH 4/9] Change mi_parse_argv to a method Tom Tromey
2023-04-04 17:08 ` [PATCH 5/9] Introduce "static constructor" for mi_parse Tom Tromey
2023-04-04 17:08 ` [PATCH 6/9] Introduce mi_parse helper methods Tom Tromey
2023-04-04 17:08 ` [PATCH 7/9] Add second mi_parse constructor Tom Tromey
2023-04-04 17:08 ` [PATCH 8/9] Implement gdb.execute_mi Tom Tromey
2023-04-04 19:08 ` Eli Zaretskii
2023-05-18 17:57 ` Tom Tromey
2023-05-18 18:31 ` Eli Zaretskii
2023-05-18 20:15 ` Tom Tromey
2023-05-18 20:34 ` Matt Rice
2023-05-19 15:57 ` Tom Tromey [this message]
2023-04-04 17:08 ` [PATCH 9/9] Implement DAP loadedSources request Tom Tromey
2023-04-10 23:43 ` [PATCH 0/9] Implement the DAP "loadedSources" request Matt Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y8oz54d.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).