From: Matt Rice <ratmice@gmail.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] Implement gdb.execute_mi
Date: Thu, 18 May 2023 20:34:21 +0000 [thread overview]
Message-ID: <CACTLOFrwv863Bfp9DHQ+=oiuAuCNBmpzGtPAZXLMuczwae34Lg@mail.gmail.com> (raw)
In-Reply-To: <87a5y1z99o.fsf@tromey.com>
On Thu, May 18, 2023 at 8:15 PM Tom Tromey via Gdb-patches
<gdb-patches@sourceware.org> wrote:
>
> >> In MI, the leading '-' is not really part of the command name. It seems
> >> to be some kind of syntactic marker, though I have no idea why, as there
> >> aren't any other possible such markers as far as I can tell.
>
> Eli> I'm not going to object, but frankly, it sounds strange. Our
> Eli> documentation of MI commands includes the leading dash with each
> Eli> command, so for the reader the dash is part of the command.
>
> Alright. I made this change in v2.
I don't have much preference either way, but it brought to mind that
there are issues with kwargs,
with dict keys containing hyphens. If this were a problem though, it
would also apply to other hyphenated
command names, like 'break-insert' regardless of the initial hyphen.
I suppose that people trying to map mi commands to kwargs
would perhaps just have to mangle mi commands...
next prev parent reply other threads:[~2023-05-18 20:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:08 [PATCH 0/9] Implement the DAP "loadedSources" request Tom Tromey
2023-04-04 17:08 ` [PATCH 1/9] Use field_signed from Python MI commands Tom Tromey
2023-04-04 17:08 ` [PATCH 2/9] Use member initializers in mi_parse Tom Tromey
2023-04-04 17:08 ` [PATCH 3/9] Use accessor for mi_parse::args Tom Tromey
2023-04-04 17:08 ` [PATCH 4/9] Change mi_parse_argv to a method Tom Tromey
2023-04-04 17:08 ` [PATCH 5/9] Introduce "static constructor" for mi_parse Tom Tromey
2023-04-04 17:08 ` [PATCH 6/9] Introduce mi_parse helper methods Tom Tromey
2023-04-04 17:08 ` [PATCH 7/9] Add second mi_parse constructor Tom Tromey
2023-04-04 17:08 ` [PATCH 8/9] Implement gdb.execute_mi Tom Tromey
2023-04-04 19:08 ` Eli Zaretskii
2023-05-18 17:57 ` Tom Tromey
2023-05-18 18:31 ` Eli Zaretskii
2023-05-18 20:15 ` Tom Tromey
2023-05-18 20:34 ` Matt Rice [this message]
2023-05-19 15:57 ` Tom Tromey
2023-04-04 17:08 ` [PATCH 9/9] Implement DAP loadedSources request Tom Tromey
2023-04-10 23:43 ` [PATCH 0/9] Implement the DAP "loadedSources" request Matt Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACTLOFrwv863Bfp9DHQ+=oiuAuCNBmpzGtPAZXLMuczwae34Lg@mail.gmail.com' \
--to=ratmice@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).