Re: [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes

[Andrew Burgess <aburgess@redhat.com>]

Ping!

Thanks,
Andrew


Andrew Burgess <aburgess@redhat.com> writes:

> I pushed the first two patches from the v1 series, but the rest of
> that original series does need reviewing - those paches are included
> in v2 as patches 1 to 5.
>
> The remaining 10 patches in the v2 series mostly relate to changing
> how window resizing, and window layout occurs.
>
> The docs content in patches 1 and 5 of the v2 series is unchanged from
> v1, and was already reviewed, so no new docs review is required there.
>
> There is some new docs content in patch 6, but its pretty minor; a
> docs review is always welcome though.
>
> I'm hoping most of the changes in this series will be pretty
> non-controversial, the only patch which I think might be more of a
> personal taste issue is the very last one (left last for that reason).
> I'd suggest selecting the split layout, and then playing with window
> resizing to get a feel for the new behaviour.  Feedback welcome.
>
> Thanks,
> Andrew
>
> ---
>
> Andrew Burgess (15):
>   gdb: move some commands into the tui namespace
>   gdb/tui: rename tui_layout_base::adjust_size to ::set_height
>   gdb/tui: rename tui_layout_split:set_weights_from_heights
>   gdb/testing/tui: add new functionality to tuiterm.exp
>   gdb/tui: add new 'tui window width' command and 'winwidth' alias
>   gdb/tui: add a tui debugging flag
>   gdb/tui: add left_boxed_p and right_boxed_p member functions
>   gdb/tui/testsuite: refactor new-layout.exp test
>   gdb/tui: avoid fp exception when applying layouts
>   gdb/tui: fairer distribution of excess space during apply
>   gdb/tui: allow cmd window to change size in tui_layout_split::apply
>   gdb/tui: support placing the cmd window into a horizontal layout
>   gdb/testsuite: some additional tests in gdb.tui/scroll.exp
>   gdb/tui: relax restrictions on window max height and width
>   gdb/tui: fair split of delta after a resize
>
>  gdb/NEWS                             |  25 ++
>  gdb/doc/gdb.texinfo                  |  41 ++-
>  gdb/testsuite/gdb.tui/basic.exp      |   4 +-
>  gdb/testsuite/gdb.tui/empty.exp      |  14 +-
>  gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++--
>  gdb/testsuite/gdb.tui/regs.exp       |   4 +-
>  gdb/testsuite/gdb.tui/scroll.exp     |   4 +
>  gdb/testsuite/gdb.tui/winheight.exp  |  77 +++++
>  gdb/testsuite/gdb.tui/winwidth.exp   |  63 ++++
>  gdb/testsuite/lib/tuiterm.exp        |  82 +++++-
>  gdb/tui/tui-command.c                |   6 -
>  gdb/tui/tui-command.h                |   2 -
>  gdb/tui/tui-layout.c                 | 419 +++++++++++++++++++++++----
>  gdb/tui/tui-layout.h                 | 201 ++++++++++++-
>  gdb/tui/tui-win.c                    | 149 ++++++++--
>  gdb/tui/tui.c                        |  26 ++
>  gdb/tui/tui.h                        |  14 +
>  17 files changed, 1089 insertions(+), 142 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp
>
> -- 
> 2.25.4