From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes
Date: Sun, 6 Feb 2022 14:12:38 +0000 [thread overview]
Message-ID: <cover.1644156219.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1643385021.git.aburgess@redhat.com>
I pushed the first two patches from the v1 series, but the rest of
that original series does need reviewing - those paches are included
in v2 as patches 1 to 5.
The remaining 10 patches in the v2 series mostly relate to changing
how window resizing, and window layout occurs.
The docs content in patches 1 and 5 of the v2 series is unchanged from
v1, and was already reviewed, so no new docs review is required there.
There is some new docs content in patch 6, but its pretty minor; a
docs review is always welcome though.
I'm hoping most of the changes in this series will be pretty
non-controversial, the only patch which I think might be more of a
personal taste issue is the very last one (left last for that reason).
I'd suggest selecting the split layout, and then playing with window
resizing to get a feel for the new behaviour. Feedback welcome.
Thanks,
Andrew
---
Andrew Burgess (15):
gdb: move some commands into the tui namespace
gdb/tui: rename tui_layout_base::adjust_size to ::set_height
gdb/tui: rename tui_layout_split:set_weights_from_heights
gdb/testing/tui: add new functionality to tuiterm.exp
gdb/tui: add new 'tui window width' command and 'winwidth' alias
gdb/tui: add a tui debugging flag
gdb/tui: add left_boxed_p and right_boxed_p member functions
gdb/tui/testsuite: refactor new-layout.exp test
gdb/tui: avoid fp exception when applying layouts
gdb/tui: fairer distribution of excess space during apply
gdb/tui: allow cmd window to change size in tui_layout_split::apply
gdb/tui: support placing the cmd window into a horizontal layout
gdb/testsuite: some additional tests in gdb.tui/scroll.exp
gdb/tui: relax restrictions on window max height and width
gdb/tui: fair split of delta after a resize
gdb/NEWS | 25 ++
gdb/doc/gdb.texinfo | 41 ++-
gdb/testsuite/gdb.tui/basic.exp | 4 +-
gdb/testsuite/gdb.tui/empty.exp | 14 +-
gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++--
gdb/testsuite/gdb.tui/regs.exp | 4 +-
gdb/testsuite/gdb.tui/scroll.exp | 4 +
gdb/testsuite/gdb.tui/winheight.exp | 77 +++++
gdb/testsuite/gdb.tui/winwidth.exp | 63 ++++
gdb/testsuite/lib/tuiterm.exp | 82 +++++-
gdb/tui/tui-command.c | 6 -
gdb/tui/tui-command.h | 2 -
gdb/tui/tui-layout.c | 419 +++++++++++++++++++++++----
gdb/tui/tui-layout.h | 201 ++++++++++++-
gdb/tui/tui-win.c | 149 ++++++++--
gdb/tui/tui.c | 26 ++
gdb/tui/tui.h | 14 +
17 files changed, 1089 insertions(+), 142 deletions(-)
create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp
--
2.25.4
next prev parent reply other threads:[~2022-02-06 14:13 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 15:55 [PATCH 0/7] TUI command changes, including new winwidth command Andrew Burgess
2022-01-28 15:55 ` [PATCH 1/7] gdb/tui: add window width information to 'info win' output Andrew Burgess
2022-01-28 17:00 ` Eli Zaretskii
2022-02-06 13:43 ` Andrew Burgess
2022-01-28 15:55 ` [PATCH 2/7] gdb/doc: update docs for 'info win' and 'winheight' commands Andrew Burgess
2022-01-28 17:03 ` Eli Zaretskii
2022-02-06 13:43 ` Andrew Burgess
2022-01-28 15:55 ` [PATCH 3/7] gdb: move some commands into the tui namespace Andrew Burgess
2022-01-28 17:04 ` Eli Zaretskii
2022-01-28 15:55 ` [PATCH 4/7] gdb/tui: rename tui_layout_base::adjust_size to ::set_height Andrew Burgess
2022-01-28 15:55 ` [PATCH 5/7] gdb/tui: rename tui_layout_split:set_weights_from_heights Andrew Burgess
2022-01-28 15:55 ` [PATCH 6/7] gdb/testing/tui: add new functionality to tuiterm.exp Andrew Burgess
2022-01-28 15:55 ` [PATCH 7/7] gdb/tui: add new 'tui window width' command and 'winwidth' alias Andrew Burgess
2022-01-28 17:05 ` Eli Zaretskii
2022-02-06 14:12 ` Andrew Burgess [this message]
2022-02-06 14:12 ` [PATCHv2 01/15] gdb: move some commands into the tui namespace Andrew Burgess
2022-02-06 15:50 ` Eli Zaretskii
2022-02-06 14:12 ` [PATCHv2 02/15] gdb/tui: rename tui_layout_base::adjust_size to ::set_height Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 03/15] gdb/tui: rename tui_layout_split:set_weights_from_heights Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 04/15] gdb/testing/tui: add new functionality to tuiterm.exp Andrew Burgess
2022-03-04 16:29 ` Tom Tromey
2022-02-06 14:12 ` [PATCHv2 05/15] gdb/tui: add new 'tui window width' command and 'winwidth' alias Andrew Burgess
2022-02-06 15:52 ` Eli Zaretskii
2022-02-09 15:33 ` Andrew Burgess
2022-02-09 17:03 ` Eli Zaretskii
2022-03-03 18:52 ` Pedro Alves
2022-02-06 14:12 ` [PATCHv2 06/15] gdb/tui: add a tui debugging flag Andrew Burgess
2022-02-06 15:53 ` Eli Zaretskii
2022-03-04 16:35 ` Tom Tromey
2022-02-06 14:12 ` [PATCHv2 07/15] gdb/tui: add left_boxed_p and right_boxed_p member functions Andrew Burgess
2022-03-04 16:37 ` Tom Tromey
2022-02-06 14:12 ` [PATCHv2 08/15] gdb/tui/testsuite: refactor new-layout.exp test Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 09/15] gdb/tui: avoid fp exception when applying layouts Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 10/15] gdb/tui: fairer distribution of excess space during apply Andrew Burgess
2022-03-04 16:42 ` Tom Tromey
2022-02-06 14:12 ` [PATCHv2 11/15] gdb/tui: allow cmd window to change size in tui_layout_split::apply Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 12/15] gdb/tui: support placing the cmd window into a horizontal layout Andrew Burgess
2022-03-04 17:17 ` Tom Tromey
2022-03-07 20:05 ` Andrew Burgess
2022-03-07 21:24 ` Tom Tromey
2022-02-06 14:12 ` [PATCHv2 13/15] gdb/testsuite: some additional tests in gdb.tui/scroll.exp Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 14/15] gdb/tui: relax restrictions on window max height and width Andrew Burgess
2022-03-04 17:20 ` Tom Tromey
2022-03-07 20:08 ` Andrew Burgess
2022-02-06 14:12 ` [PATCHv2 15/15] gdb/tui: fair split of delta after a resize Andrew Burgess
2022-03-04 17:22 ` Tom Tromey
2022-03-07 22:07 ` Andrew Burgess
2022-03-07 23:42 ` Tom Tromey
2022-02-21 17:29 ` [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes Andrew Burgess
2022-03-02 17:59 ` Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 " Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 01/15] gdb: move some commands into the tui namespace Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 02/15] gdb/tui: rename tui_layout_base::adjust_size to ::set_height Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 03/15] gdb/tui: rename tui_layout_split:set_weights_from_heights Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 04/15] gdb/testing/tui: add new functionality to tuiterm.exp Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 05/15] gdb/tui: add new 'tui window width' command and 'winwidth' alias Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 06/15] gdb/tui: add a tui debugging flag Andrew Burgess
2022-03-08 12:16 ` Eli Zaretskii
2022-03-09 11:48 ` Andrew Burgess
2022-03-09 12:58 ` Eli Zaretskii
2022-03-09 17:53 ` Tom Tromey
2022-03-07 22:13 ` [PATCHv3 07/15] gdb/tui: add left_boxed_p and right_boxed_p member functions Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 08/15] gdb/tui/testsuite: refactor new-layout.exp test Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 09/15] gdb/tui: avoid fp exception when applying layouts Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 10/15] gdb/tui: fairer distribution of excess space during apply Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 11/15] gdb/tui: allow cmd window to change size in tui_layout_split::apply Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 12/15] gdb/tui: support placing the cmd window into a horizontal layout Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 13/15] gdb/testsuite: some additional tests in gdb.tui/scroll.exp Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 14/15] gdb/tui: relax restrictions on window max height and width Andrew Burgess
2022-03-07 22:13 ` [PATCHv3 15/15] gdb/tui: fair split of delta after a resize Andrew Burgess
2022-03-21 17:52 ` [PATCHv3 00/15] TUI changes, new winwidth command and resizing changes Andrew Burgess
2022-03-30 9:13 ` Andrew Burgess
2022-04-03 14:43 ` Andrew Burgess
2022-03-04 17:23 ` [PATCH 0/7] TUI command changes, including new winwidth command Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1644156219.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).