From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb: unbuffer all input streams when not using readline
Date: Tue, 18 Jan 2022 11:59:34 -0700 [thread overview]
Message-ID: <875yqgeup5.fsf@tromey.com> (raw)
In-Reply-To: <20220118180913.GI622389@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 18 Jan 2022 18:09:13 +0000")
Andrew> It does occur to me that some mi commands can produce a lot of
Andrew> output. So, in the new-ui case, where we have a single FILE shared
Andrew> for input and output, the unbuffering will impact output too, right,
Andrew> so maybe that's where we'd see the slow down? That case could be
Andrew> worked around by having new-ui open a new FILE for each stream.
I think it's relatively simpler to add gdb-side buffering for output
than for input. So if this is the issue, it seems not super hard to
handle -- just write a buffering ui_file.
Tom
next prev parent reply other threads:[~2022-01-18 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 16:40 Andrew Burgess
2022-01-18 16:26 ` Simon Marchi
2022-01-18 17:09 ` Andrew Burgess
2022-01-18 17:57 ` Simon Marchi
2022-01-18 18:09 ` Andrew Burgess
2022-01-18 18:59 ` Tom Tromey [this message]
2022-02-02 16:23 ` Andrew Burgess
2022-02-07 10:27 ` Andrew Burgess
2022-01-18 18:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yqgeup5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).