public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb: unbuffer all input streams when not using readline
Date: Tue, 18 Jan 2022 11:52:51 -0700	[thread overview]
Message-ID: <87a6fsev0c.fsf@tromey.com> (raw)
In-Reply-To: <20220117164051.1854133-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 17 Jan 2022 16:40:51 +0000")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> This commit should fix PR gdb/28711.  What's actually going on is
Andrew> pretty involved, and there's still a bit of the story that I don't
Andrew> understand completely, however, from my observed results, I think that
Andrew> the change I propose making here (or something very similar) is going
Andrew> to be needed.

Thanks for the great description of the problem.

I haven't read the whole thread yet but I had a couple things to mention
in response to this message.

Andrew>   3. Tom is currently doing lots of gdb stream management changes and
Andrew>   I want to minimise the chances we'll conflict.

FWIW my changes only affect output streams, I haven't touched input at
all.

Andrew> So, this commit just changes gdb_readline_no_editing_callback to
Andrew> always unbuffer the input stream.

https://sourceware.org/bugzilla/show_bug.cgi?id=7237 is about the lack
of buffering for MI.  If this patch goes in, I think we should probably
just WONTFIX this bug.

Tom

      parent reply	other threads:[~2022-01-18 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 16:40 Andrew Burgess
2022-01-18 16:26 ` Simon Marchi
2022-01-18 17:09   ` Andrew Burgess
2022-01-18 17:57     ` Simon Marchi
2022-01-18 18:09     ` Andrew Burgess
2022-01-18 18:59       ` Tom Tromey
2022-02-02 16:23   ` Andrew Burgess
2022-02-07 10:27     ` Andrew Burgess
2022-01-18 18:52 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6fsev0c.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).