From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/build] Fix frame_list position in frame.c
Date: Thu, 04 May 2023 11:01:22 +0200 [thread overview]
Message-ID: <877ctoii71.fsf@adacore.com> (raw)
In-Reply-To: <da98123c-2495-1b35-16e9-f023e95174a4@suse.de> (Tom de Vries's message of "Wed, 3 May 2023 21:45:59 +0200")
Tom de Vries <tdevries@suse.de> writes:
> On 5/3/23 20:47, Simon Marchi wrote:
>
>> In any case, this LGTM, thanks for doing this.
Seconded, thanks for getting rid of that if guard. I find the new state
of affairs (everything defined in the same unit, in the correct order)
easier to grok.
next prev parent reply other threads:[~2023-05-04 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 17:58 Tom de Vries
2023-05-03 18:47 ` Simon Marchi
2023-05-03 19:45 ` Tom de Vries
2023-05-04 9:01 ` Kévin Le Gouguec [this message]
2023-05-04 9:12 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ctoii71.fsf@adacore.com \
--to=legouguec@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).