From: Tom de Vries <tdevries@suse.de>
To: "Kévin Le Gouguec" <legouguec@adacore.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/build] Fix frame_list position in frame.c
Date: Thu, 4 May 2023 11:12:26 +0200 [thread overview]
Message-ID: <f3eca976-5081-4e83-a967-5019298f19d9@suse.de> (raw)
In-Reply-To: <877ctoii71.fsf@adacore.com>
On 5/4/23 11:01, Kévin Le Gouguec wrote:
> Tom de Vries <tdevries@suse.de> writes:
>
>> On 5/3/23 20:47, Simon Marchi wrote:
>>
>>> In any case, this LGTM, thanks for doing this.
>
> Seconded, thanks for getting rid of that if guard. I find the new state
> of affairs (everything defined in the same unit, in the correct order)
> easier to grok.
Hi Kévin,
thanks for the review and the confirmation.
- Tom
prev parent reply other threads:[~2023-05-04 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 17:58 Tom de Vries
2023-05-03 18:47 ` Simon Marchi
2023-05-03 19:45 ` Tom de Vries
2023-05-04 9:01 ` Kévin Le Gouguec
2023-05-04 9:12 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3eca976-5081-4e83-a967-5019298f19d9@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=legouguec@adacore.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).