From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader
Date: Tue, 17 Jan 2023 11:46:39 -0700 [thread overview]
Message-ID: <877cxl2e40.fsf@tromey.com> (raw)
In-Reply-To: <c9c31c0e-283e-bb45-411d-98f14ac0a97d@suse.de> (Tom de Vries's message of "Tue, 17 Jan 2023 17:44:51 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> On 1/14/23 07:11, Joel Brobecker via Gdb-patches wrote:
>> +if { [skip_cplus_tests] } { continue }
Tom> This uses the old syntax, so we get:
Tom> ...
Tom> ERROR: tcl error sourcing src/gdb/testsuite/gdb.cp/paramless.exp.
Tom> ERROR: invalid command name "skip_cplus_tests"
Tom> while executing
Tom> ...
Sorry about that. I see now that my test comparison script doesn't
account for ERROR / UNRESOLVED :(
I'm going to check in the appended.
Tom
commit fbd6525ba66d9c6c98cf57223d6ad09df1274d67
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Jan 17 11:45:40 2023 -0700
Use require in paramless.exp
The new paramless.exp test was not converted to the new "require"
approach. This patch fixes the problem.
diff --git a/gdb/testsuite/gdb.cp/paramless.exp b/gdb/testsuite/gdb.cp/paramless.exp
index 79529de49f5..579f363d6a0 100644
--- a/gdb/testsuite/gdb.cp/paramless.exp
+++ b/gdb/testsuite/gdb.cp/paramless.exp
@@ -17,7 +17,7 @@
# Test template breakpoints without parameters.
-if { [skip_cplus_tests] } { continue }
+require allow_cplus_tests
standard_testfile .cc
next prev parent reply other threads:[~2023-01-17 18:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:33 [PATCH v2 0/4] Fix " Tom Tromey
2023-01-10 18:33 ` [PATCH v2 1/4] Avoid submitting empty tasks in parallel_for_each Tom Tromey
2023-01-14 6:03 ` Joel Brobecker
2023-01-10 18:33 ` [PATCH v2 2/4] Don't erase empty indices in DWARF reader Tom Tromey
2023-01-14 6:05 ` Joel Brobecker
2023-01-17 13:53 ` Tom Tromey
2023-01-10 18:33 ` [PATCH v2 3/4] Move hash_entry and eq_entry into cooked_index::do_finalize Tom Tromey
2023-01-14 6:06 ` Joel Brobecker
2023-01-10 18:33 ` [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader Tom Tromey
2023-01-14 6:11 ` Joel Brobecker
2023-01-17 13:54 ` Tom Tromey
2023-01-17 16:44 ` Tom de Vries
2023-01-17 18:46 ` Tom Tromey [this message]
2023-01-17 18:09 ` Simon Marchi
2023-01-17 19:39 ` Tom Tromey
2023-01-27 5:47 ` Simon Marchi
2023-01-27 10:15 ` Andrew Burgess
2023-01-27 14:30 ` Tom Tromey
2023-01-27 19:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cxl2e40.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).