From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>, Tom Tromey <tromey@adacore.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader
Date: Fri, 27 Jan 2023 07:30:36 -0700 [thread overview]
Message-ID: <87ilgsqcc3.fsf@tromey.com> (raw)
In-Reply-To: <87wn58uvuu.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 27 Jan 2023 10:15:21 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Sorry I haven't gotten back to fixing this. I've been pretty busy with
a project at work, my other patches have all been rote stuff.
Andrew> The underlying problem is that we use a different sort predicate for the
Andrew> std::lower_bound and std::upper_bound calls (in some cases) than when we
Andrew> sorted this list. I'm not sure this can ever work correctly.
Yeah, that was my conclusion as well.
My plan is to sort more naively again (writing our own strcasecmp though
to avoid the performance thing on Windows), then have either the 'find'
method or the caller in read.c do an extra filtering.
Tom
next prev parent reply other threads:[~2023-01-27 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:33 [PATCH v2 0/4] Fix " Tom Tromey
2023-01-10 18:33 ` [PATCH v2 1/4] Avoid submitting empty tasks in parallel_for_each Tom Tromey
2023-01-14 6:03 ` Joel Brobecker
2023-01-10 18:33 ` [PATCH v2 2/4] Don't erase empty indices in DWARF reader Tom Tromey
2023-01-14 6:05 ` Joel Brobecker
2023-01-17 13:53 ` Tom Tromey
2023-01-10 18:33 ` [PATCH v2 3/4] Move hash_entry and eq_entry into cooked_index::do_finalize Tom Tromey
2023-01-14 6:06 ` Joel Brobecker
2023-01-10 18:33 ` [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader Tom Tromey
2023-01-14 6:11 ` Joel Brobecker
2023-01-17 13:54 ` Tom Tromey
2023-01-17 16:44 ` Tom de Vries
2023-01-17 18:46 ` Tom Tromey
2023-01-17 18:09 ` Simon Marchi
2023-01-17 19:39 ` Tom Tromey
2023-01-27 5:47 ` Simon Marchi
2023-01-27 10:15 ` Andrew Burgess
2023-01-27 14:30 ` Tom Tromey [this message]
2023-01-27 19:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilgsqcc3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).