From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/4] Don't erase empty indices in DWARF reader
Date: Mon, 09 Jan 2023 11:18:11 -0700 [thread overview]
Message-ID: <877cxva7x8.fsf@tromey.com> (raw)
In-Reply-To: <87k01vac81.fsf@tromey.com> (Tom Tromey's message of "Mon, 09 Jan 2023 09:45:18 -0700")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> I think it may be best to just drop this patch and leave the current
Tom> code in place. It doesn't do anything, but on the other hand, this
Tom> seems to be non-obvious, so it may serve a useful assurance purpose.
It occurred to me today that another approach might be to add a
self-test for this -- that is, use parallel-for-each on (say) a single
task but when multiple threads are available. Then, it could check that
there are no NULL responses.
Tom
next prev parent reply other threads:[~2023-01-09 18:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 19:07 [PATCH 0/4] Fix regression in new " Tom Tromey
2022-12-15 19:07 ` [PATCH 1/4] Avoid submitting empty tasks in parallel_for_each Tom Tromey
2023-01-07 11:19 ` Joel Brobecker
2023-01-09 16:20 ` Tom Tromey
2022-12-15 19:07 ` [PATCH 2/4] Don't erase empty indices in DWARF reader Tom Tromey
2022-12-19 14:51 ` Andrew Burgess
2022-12-19 17:09 ` Tom Tromey
2023-01-07 11:24 ` Joel Brobecker
2023-01-09 16:45 ` Tom Tromey
2023-01-09 18:18 ` Tom Tromey [this message]
2023-01-10 10:07 ` Andrew Burgess
2023-01-10 18:24 ` Tom Tromey
2022-12-15 19:07 ` [PATCH 3/4] Move hash_entry and eq_entry into cooked_index::do_finalize Tom Tromey
2023-01-07 11:26 ` Joel Brobecker
2022-12-15 19:07 ` [PATCH 4/4] Fix parameter-less template regression in new DWARF reader Tom Tromey
2023-01-07 11:37 ` Joel Brobecker
2023-01-07 11:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cxva7x8.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).