From: Tom Tromey <tromey@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>,
Andrew Burgess <aburgess@redhat.com>,
Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 2/4] Don't erase empty indices in DWARF reader
Date: Mon, 09 Jan 2023 09:45:18 -0700 [thread overview]
Message-ID: <87k01vac81.fsf@tromey.com> (raw)
In-Reply-To: <Y7lWWZXxBVJzWRFH@adacore.com> (Joel Brobecker's message of "Sat, 7 Jan 2023 15:24:09 +0400")
Joel> If we believe the code is dead, let's drop it.
Joel> Maybe Andrew's assert suggestion could be helpful, although perhaps
Joel> a complaint might be a better compromise in this case, as I would say
Joel> a violation of this expectation would still mean a usable debugging
Joel> experience for the user, so let's not break things with an assert?
I think a complaint would be incorrect here. Normally complaints are
reserved for bad debug information, but this is just an internal aspect
of the code -- the contract of parallel-for.
I think it may be best to just drop this patch and leave the current
code in place. It doesn't do anything, but on the other hand, this
seems to be non-obvious, so it may serve a useful assurance purpose.
Tom
next prev parent reply other threads:[~2023-01-09 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 19:07 [PATCH 0/4] Fix regression in new " Tom Tromey
2022-12-15 19:07 ` [PATCH 1/4] Avoid submitting empty tasks in parallel_for_each Tom Tromey
2023-01-07 11:19 ` Joel Brobecker
2023-01-09 16:20 ` Tom Tromey
2022-12-15 19:07 ` [PATCH 2/4] Don't erase empty indices in DWARF reader Tom Tromey
2022-12-19 14:51 ` Andrew Burgess
2022-12-19 17:09 ` Tom Tromey
2023-01-07 11:24 ` Joel Brobecker
2023-01-09 16:45 ` Tom Tromey [this message]
2023-01-09 18:18 ` Tom Tromey
2023-01-10 10:07 ` Andrew Burgess
2023-01-10 18:24 ` Tom Tromey
2022-12-15 19:07 ` [PATCH 3/4] Move hash_entry and eq_entry into cooked_index::do_finalize Tom Tromey
2023-01-07 11:26 ` Joel Brobecker
2022-12-15 19:07 ` [PATCH 4/4] Fix parameter-less template regression in new DWARF reader Tom Tromey
2023-01-07 11:37 ` Joel Brobecker
2023-01-07 11:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k01vac81.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).