From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 2/4] Don't erase empty indices in DWARF reader
Date: Thu, 15 Dec 2022 12:07:57 -0700 [thread overview]
Message-ID: <20221215190759.2494095-3-tromey@adacore.com> (raw)
In-Reply-To: <20221215190759.2494095-1-tromey@adacore.com>
The DWARF reader has some code to remove empty indices. However, I
think this code has been obsolete since some earlier changes to
parallel_for_each. This patch removes this code.
---
gdb/dwarf2/read.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 032e20af93a..a3f4ef351eb 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_objfile)
print_tu_stats (per_objfile);
indexes.push_back (index_storage.release ());
- /* Remove any NULL entries. This might happen if parallel-for
- decides to throttle the number of threads that were used. */
- indexes.erase
- (std::remove_if (indexes.begin (),
- indexes.end (),
- [] (const std::unique_ptr<cooked_index> &entry)
- {
- return entry == nullptr;
- }),
- indexes.end ());
indexes.shrink_to_fit ();
cooked_index_vector *vec = new cooked_index_vector (std::move (indexes));
--
2.34.3
next prev parent reply other threads:[~2022-12-15 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 19:07 [PATCH 0/4] Fix regression in new " Tom Tromey
2022-12-15 19:07 ` [PATCH 1/4] Avoid submitting empty tasks in parallel_for_each Tom Tromey
2023-01-07 11:19 ` Joel Brobecker
2023-01-09 16:20 ` Tom Tromey
2022-12-15 19:07 ` Tom Tromey [this message]
2022-12-19 14:51 ` [PATCH 2/4] Don't erase empty indices in DWARF reader Andrew Burgess
2022-12-19 17:09 ` Tom Tromey
2023-01-07 11:24 ` Joel Brobecker
2023-01-09 16:45 ` Tom Tromey
2023-01-09 18:18 ` Tom Tromey
2023-01-10 10:07 ` Andrew Burgess
2023-01-10 18:24 ` Tom Tromey
2022-12-15 19:07 ` [PATCH 3/4] Move hash_entry and eq_entry into cooked_index::do_finalize Tom Tromey
2023-01-07 11:26 ` Joel Brobecker
2022-12-15 19:07 ` [PATCH 4/4] Fix parameter-less template regression in new DWARF reader Tom Tromey
2023-01-07 11:37 ` Joel Brobecker
2023-01-07 11:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215190759.2494095-3-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).