public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Change location_to_sals to a method
Date: Sat, 13 Aug 2022 18:44:55 -0600	[thread overview]
Message-ID: <877d3bwt4o.fsf@tromey.com> (raw)
In-Reply-To: <a66bd2f6-05d4-e326-2647-9dc5cddc708b@palves.net> (Pedro Alves's message of "Mon, 30 May 2022 16:32:16 +0100")

>> int thread, task;

Pedro> These thread/task are masking the breakpoint fields, and then ...
...
Pedro> ... here you end up with self assignments.

I've fixed these.

In the end my -Wshadow experiments seem half-baked, so I haven't pursued
them.  I do have a compiler hack, but it's not suitable for putting into
the compiler.  Also it causes a lot of somewhat questionable changes,
like requiring us to rename the parameters to constructors in a lot of
places.

Tom

  parent reply	other threads:[~2022-08-14  0:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28  2:42 [PATCH 0/3] More minor breakpoint cleanups Tom Tromey
2022-05-28  2:42 ` [PATCH 1/3] Change breakpoint_re_set_default to a method Tom Tromey
2022-05-30 15:32   ` Pedro Alves
2022-05-28  2:42 ` [PATCH 2/3] Change location_to_sals " Tom Tromey
2022-05-30 15:32   ` Pedro Alves
2022-06-01  4:50     ` Tom Tromey
2022-06-01 16:38       ` Pedro Alves
2022-06-10 21:34         ` Tom Tromey
2022-06-13 14:36           ` Pedro Alves
2022-08-14  0:44     ` Tom Tromey [this message]
2022-05-28  2:42 ` [PATCH 3/3] Move decode_location to code_breakpoint Tom Tromey
2022-05-30 15:42   ` Pedro Alves
2022-08-14  0:41     ` Tom Tromey
2022-08-14  0:45 ` [PATCH 0/3] More minor breakpoint cleanups Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d3bwt4o.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).