From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Change location_to_sals to a method
Date: Fri, 10 Jun 2022 15:34:46 -0600 [thread overview]
Message-ID: <87ilp819u1.fsf@tromey.com> (raw)
In-Reply-To: <321dffd0-2c41-7c78-a24f-a920ff30afd6@palves.net> (Pedro Alves's message of "Wed, 1 Jun 2022 17:38:46 +0100")
Pedro> Maybe we could give -Wshadow another try.
I looked into this. I got pretty far along, and it wouldn't be too hard
to finish. However, GCC does issue complaints about some conflicts that
don't and probably wouldn't ever find real bugs.
As simple example is that the 'gdbarch_tdep' function conflicts with
'struct gdbarch_tdep' (or maybe with its purported constructor). There
are a surprising number of these because it's common to give the same
name to a frame cache struct and corresponding unwinding function.
Anyway, I can finish the series if you think it's worthwhile.
I started hacking up a compiler patch instead but TBH I doubt I'll
finish that.
Tom
next prev parent reply other threads:[~2022-06-10 21:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 2:42 [PATCH 0/3] More minor breakpoint cleanups Tom Tromey
2022-05-28 2:42 ` [PATCH 1/3] Change breakpoint_re_set_default to a method Tom Tromey
2022-05-30 15:32 ` Pedro Alves
2022-05-28 2:42 ` [PATCH 2/3] Change location_to_sals " Tom Tromey
2022-05-30 15:32 ` Pedro Alves
2022-06-01 4:50 ` Tom Tromey
2022-06-01 16:38 ` Pedro Alves
2022-06-10 21:34 ` Tom Tromey [this message]
2022-06-13 14:36 ` Pedro Alves
2022-08-14 0:44 ` Tom Tromey
2022-05-28 2:42 ` [PATCH 3/3] Move decode_location to code_breakpoint Tom Tromey
2022-05-30 15:42 ` Pedro Alves
2022-08-14 0:41 ` Tom Tromey
2022-08-14 0:45 ` [PATCH 0/3] More minor breakpoint cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilp819u1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).