From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Move decode_location to code_breakpoint
Date: Sat, 13 Aug 2022 18:41:54 -0600 [thread overview]
Message-ID: <87bksnwt9p.fsf@tromey.com> (raw)
In-Reply-To: <d1dc45f1-c2a1-838d-eb2f-ed5a1ec2fa07@palves.net> (Pedro Alves's message of "Mon, 30 May 2022 16:42:09 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>> + /* Given the location (second parameter), this method decodes it and
Pedro> I've noticed that "second" here got stale when this was first
Pedro> converted to a method. I think we should just remove the parenthetical
Pedro> remark and be done with it. Would you mind doing that while at it?
Pedro> The patch looks OK, regardless.
I made this change.
Tom
next prev parent reply other threads:[~2022-08-14 0:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 2:42 [PATCH 0/3] More minor breakpoint cleanups Tom Tromey
2022-05-28 2:42 ` [PATCH 1/3] Change breakpoint_re_set_default to a method Tom Tromey
2022-05-30 15:32 ` Pedro Alves
2022-05-28 2:42 ` [PATCH 2/3] Change location_to_sals " Tom Tromey
2022-05-30 15:32 ` Pedro Alves
2022-06-01 4:50 ` Tom Tromey
2022-06-01 16:38 ` Pedro Alves
2022-06-10 21:34 ` Tom Tromey
2022-06-13 14:36 ` Pedro Alves
2022-08-14 0:44 ` Tom Tromey
2022-05-28 2:42 ` [PATCH 3/3] Move decode_location to code_breakpoint Tom Tromey
2022-05-30 15:42 ` Pedro Alves
2022-08-14 0:41 ` Tom Tromey [this message]
2022-08-14 0:45 ` [PATCH 0/3] More minor breakpoint cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bksnwt9p.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).