* [PATCH] [gdb/testsuite] Remove KFAIL for PR ada/30908
@ 2024-02-27 11:23 Tom de Vries
2024-02-27 14:05 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2024-02-27 11:23 UTC (permalink / raw)
To: gdb-patches
PR ada/30908 turns out to be a duplicate of PR ada/12607, which was fixed by
commit d56fdf1b976 ("Refine Ada overload matching").
Remove the KFAILs for PR ada/30908.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.ada/str_binop_equal.exp | 20 ++--------------
gdb/testsuite/gdb.ada/widewide.exp | 28 ++---------------------
2 files changed, 4 insertions(+), 44 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/str_binop_equal.exp b/gdb/testsuite/gdb.ada/str_binop_equal.exp
index 470fda0f129..943e0a6c414 100644
--- a/gdb/testsuite/gdb.ada/str_binop_equal.exp
+++ b/gdb/testsuite/gdb.ada/str_binop_equal.exp
@@ -31,24 +31,8 @@ runto "foo_p211_061.adb:$bp_location"
gdb_test "print my_str = my_str" \
" = true"
-set kfail_re \
- [multi_line \
- [string_to_regexp {Symbol: ada.strings.maps."="}] \
- ".*" \
- "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_str = "ABCD"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_str = \"ABCD\"" \
+ " = true"
gdb_test "print my_str = \"EFGH\"" \
" = false"
diff --git a/gdb/testsuite/gdb.ada/widewide.exp b/gdb/testsuite/gdb.ada/widewide.exp
index 241f0a019c2..f1ce084667f 100644
--- a/gdb/testsuite/gdb.ada/widewide.exp
+++ b/gdb/testsuite/gdb.ada/widewide.exp
@@ -42,33 +42,9 @@ gdb_test "print my_wws(1)" "= 32 ' '"
gdb_test "print my_wws(2)" "= 104 'h'"
-set kfail_re \
- [multi_line \
- [string_to_regexp {Symbol: ada.strings.maps."="}] \
- ".*" \
- "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_wws = " helo"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-gdb_test_multiple {print my_ws = "wide"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_wws = \" helo\"" " = true"
+gdb_test "print my_ws = \"wide\"" " = true"
gdb_test "print my_ws = \"nope\"" " = false"
gdb_test "print \"x\" & my_ws & \"y\"" " = \"xwidey\""
base-commit: 54af729da143016b234750b88853209c142ae5e7
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [gdb/testsuite] Remove KFAIL for PR ada/30908
2024-02-27 11:23 [PATCH] [gdb/testsuite] Remove KFAIL for PR ada/30908 Tom de Vries
@ 2024-02-27 14:05 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2024-02-27 14:05 UTC (permalink / raw)
To: Tom de Vries; +Cc: gdb-patches
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> PR ada/30908 turns out to be a duplicate of PR ada/12607, which was fixed by
Tom> commit d56fdf1b976 ("Refine Ada overload matching").
Tom> Remove the KFAILs for PR ada/30908.
Tom> Tested on x86_64-linux.
This probably needs a "Bug:" trailer?
Anyway, thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-27 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 11:23 [PATCH] [gdb/testsuite] Remove KFAIL for PR ada/30908 Tom de Vries
2024-02-27 14:05 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).