public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>,  Tom Tromey <tom@tromey.com>
Subject: Re: [pushed] [gdb/tui] Fix TUI resizing for TERM=ansi
Date: Sun, 30 Apr 2023 13:15:13 -0600	[thread overview]
Message-ID: <878re9mbb2.fsf@tromey.com> (raw)
In-Reply-To: <20230430110647.975-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Sun, 30 Apr 2023 13:06:47 +0200")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> As it happens, when TERM is set to ansi, readline decides that the terminal
Tom> cannot auto-wrap lines, and reserves one column to deal with that, and as a
Tom> result reports back one less than the actual screen width:
...
Tom> This is currently not causing trouble in testing because we have a workaround
Tom> in place in proc Term::resize.  If we disable the workaround:

Thank you for tracking this down.
I never even considered this might be a readline issue.

Tom> +      readline_hidden_cols = _rl_term_autowrap ? 0 : 1;

I hate to have a new dependency on a readline internal variable.
Don't some distros mark these as hidden in libreadline.so?
I feel like there was another bug along these lines.

However, I don't see another way to do it.
Maybe some official API could be added by the upstream readline.
Would you want to bring it up there?

Anyway it seems ok to me.

thanks,
Tom

  reply	other threads:[~2023-04-30 19:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 11:06 Tom de Vries
2023-04-30 19:15 ` Tom Tromey [this message]
2023-05-01  7:45   ` [PATCH] [gdb/build] Remove dependency on _rl_term_autowrap Tom de Vries
2023-05-16  8:53     ` [PING][PATCH] " Tom de Vries
2023-06-19 11:55       ` [PING^2][PATCH] " Tom de Vries
2023-12-15 19:46     ` [PATCH] " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878re9mbb2.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).