From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] [gdb/build] Remove dependency on _rl_term_autowrap
Date: Fri, 15 Dec 2023 12:46:20 -0700 [thread overview]
Message-ID: <87sf435jw3.fsf@tromey.com> (raw)
In-Reply-To: <e23f5b41-9f7f-e47c-f46b-5cf64e531301@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 1 May 2023 09:45:12 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>> However, I don't see another way to do it.
Tom> I had an earlier version of the patch that used the COLUMNS env
Tom> variable instead. It felt a bit hacky, so I went for
Tom> _rl_term_autowrap, but patch attached below goes back to the COLUMNS
Tom> approach. WDYT?
Looks good to me. Maybe one nit:
Tom> + char *columns_env_str = getenv ("COLUMNS");
... mildly better to write "const char *" here.
Tom
prev parent reply other threads:[~2023-12-15 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 11:06 [pushed] [gdb/tui] Fix TUI resizing for TERM=ansi Tom de Vries
2023-04-30 19:15 ` Tom Tromey
2023-05-01 7:45 ` [PATCH] [gdb/build] Remove dependency on _rl_term_autowrap Tom de Vries
2023-05-16 8:53 ` [PING][PATCH] " Tom de Vries
2023-06-19 11:55 ` [PING^2][PATCH] " Tom de Vries
2023-12-15 19:46 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf435jw3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).