From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Hannes Domani <ssbssa@yahoo.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Fix control-c handling on Windows
Date: Mon, 12 Dec 2022 10:05:21 -0700 [thread overview]
Message-ID: <878rjch7se.fsf@tromey.com> (raw)
In-Reply-To: <87cz8ohbwf.fsf@tromey.com> (Tom Tromey's message of "Mon, 12 Dec 2022 08:36:32 -0700")
Tom> I used RDP and started powershell, then ran gdb there. I did 6 tests: a
Tom> C-c and a C-break test of "run", "run" with "set new-console 1", and
Tom> "attach" -- and in all these cases, it worked.
I found out how to reproduce the crash you saw. In my tests, I was
doing everything in a single gdb instance. However, if I start a new
gdb, then "set new-console 1", and then "run", I can make it crash.
Changing sigint_ours to a gdb::optional fixes this problem.
I couldn't reproduce your problem #3 ... my python-less build seems to
work fine in other situations.
I'll send v2 of this series shortly.
Tom
next prev parent reply other threads:[~2022-12-12 17:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 18:56 [PATCH 0/3] Fix Windows C-c handling Tom Tromey
2022-12-05 18:56 ` [PATCH 1/3] Rename install_sigint_handler Tom Tromey
2022-12-05 18:56 ` [PATCH 2/3] Refactor code to check for terminal sharing Tom Tromey
2022-12-05 19:50 ` Eli Zaretskii
2022-12-12 17:27 ` Tom Tromey
2022-12-05 18:56 ` [PATCH 3/3] Fix control-c handling on Windows Tom Tromey
2022-12-07 17:13 ` Hannes Domani
2022-12-09 15:58 ` Tom Tromey
2022-12-09 16:19 ` Hannes Domani
2022-12-09 17:20 ` Tom Tromey
2022-12-09 18:13 ` Hannes Domani
2022-12-12 15:36 ` Tom Tromey
2022-12-12 17:05 ` Tom Tromey [this message]
2022-12-13 11:30 ` Hannes Domani
2022-12-13 19:51 ` Tom Tromey
2022-12-05 18:59 ` [PATCH 0/3] Fix Windows C-c handling Tom Tromey
2022-12-12 13:23 ` Jon Turney
2022-12-12 17:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjch7se.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).