From: Tom Tromey <tromey@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Refactor code to check for terminal sharing
Date: Mon, 12 Dec 2022 10:27:34 -0700 [thread overview]
Message-ID: <874ju0h6rd.fsf@tromey.com> (raw)
In-Reply-To: <83359t8wai.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Dec 2022 21:50:29 +0200")
>> Cc: Tom Tromey <tromey@adacore.com>
>> Date: Mon, 5 Dec 2022 11:56:50 -0700
>> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
>>
>> One thing I'm not sure of here is how GetConsoleProcessList will work
>> in all situations. MSDN has a warning about it:
>>
>> This API is not recommended and does not have a virtual terminal
>> equivalent. [...] Applications remoting via cross-platform
>> utilities and transports like SSH may not work as expected if
>> using this API.
Eli> AFAIU the warning, we have no reasons to be afraid of using this API.
Thanks. I've updated the commit message to reflect this.
Tom
next prev parent reply other threads:[~2022-12-12 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 18:56 [PATCH 0/3] Fix Windows C-c handling Tom Tromey
2022-12-05 18:56 ` [PATCH 1/3] Rename install_sigint_handler Tom Tromey
2022-12-05 18:56 ` [PATCH 2/3] Refactor code to check for terminal sharing Tom Tromey
2022-12-05 19:50 ` Eli Zaretskii
2022-12-12 17:27 ` Tom Tromey [this message]
2022-12-05 18:56 ` [PATCH 3/3] Fix control-c handling on Windows Tom Tromey
2022-12-07 17:13 ` Hannes Domani
2022-12-09 15:58 ` Tom Tromey
2022-12-09 16:19 ` Hannes Domani
2022-12-09 17:20 ` Tom Tromey
2022-12-09 18:13 ` Hannes Domani
2022-12-12 15:36 ` Tom Tromey
2022-12-12 17:05 ` Tom Tromey
2022-12-13 11:30 ` Hannes Domani
2022-12-13 19:51 ` Tom Tromey
2022-12-05 18:59 ` [PATCH 0/3] Fix Windows C-c handling Tom Tromey
2022-12-12 13:23 ` Jon Turney
2022-12-12 17:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ju0h6rd.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).