From: Tom Tromey <tromey@adacore.com>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/3] Fix Windows C-c handling
Date: Mon, 12 Dec 2022 10:29:42 -0700 [thread overview]
Message-ID: <87zgbsfs3d.fsf@tromey.com> (raw)
In-Reply-To: <c0eeecec-1891-ff2f-a673-b423b0cceb21@dronecode.org.uk> (Jon Turney's message of "Mon, 12 Dec 2022 13:23:57 +0000")
>>>>> "Jon" == Jon Turney <jon.turney@dronecode.org.uk> writes:
Jon> On 05/12/2022 18:59, Tom Tromey wrote:
Tom> This series attempts to fix C-c handling on Windows, which was broken
Tom> by target async.
>> Jon, would you mind testing this on Cygwin? I can't really do that,
>> but
>> I'd rather not break the build again.
>> The branch is in my github as 'submit/windows-c-c', which may be
>> more
>> convenient than applying via email.
Jon> Thanks.
Jon> This compiles ok, and seems to work.
Thanks for trying it.
Jon> I'm sure how, since my theory was that Cygwin should continue to use
Jon> GenerateConsoleCtrlEvent() on the inferior, which would then
Jon> experience a SIGINT in the Cygwin runtime, and gdb gets told about
Jon> that emulated signal and stops the inferior.
Jon> (In practice, I don't think that reliably worked before, and I have
Jon> precisely zero time to look into this currently, so go ahead...)
I don't know either :) If it works for you then that seems pretty good;
and we can always change the Cygwin code paths later if need be.
Tom
prev parent reply other threads:[~2022-12-12 17:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 18:56 Tom Tromey
2022-12-05 18:56 ` [PATCH 1/3] Rename install_sigint_handler Tom Tromey
2022-12-05 18:56 ` [PATCH 2/3] Refactor code to check for terminal sharing Tom Tromey
2022-12-05 19:50 ` Eli Zaretskii
2022-12-12 17:27 ` Tom Tromey
2022-12-05 18:56 ` [PATCH 3/3] Fix control-c handling on Windows Tom Tromey
2022-12-07 17:13 ` Hannes Domani
2022-12-09 15:58 ` Tom Tromey
2022-12-09 16:19 ` Hannes Domani
2022-12-09 17:20 ` Tom Tromey
2022-12-09 18:13 ` Hannes Domani
2022-12-12 15:36 ` Tom Tromey
2022-12-12 17:05 ` Tom Tromey
2022-12-13 11:30 ` Hannes Domani
2022-12-13 19:51 ` Tom Tromey
2022-12-05 18:59 ` [PATCH 0/3] Fix Windows C-c handling Tom Tromey
2022-12-12 13:23 ` Jon Turney
2022-12-12 17:29 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgbsfs3d.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).