public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config
Date: Mon, 18 Apr 2022 08:56:15 -0600	[thread overview]
Message-ID: <878rs2xwxc.fsf@tromey.com> (raw)
In-Reply-To: <20220329131158.3970228-3-christina.schimpe@intel.com> (Christina Schimpe via Gdb-patches's message of "Tue, 29 Mar 2022 15:11:57 +0200")

>>>>> Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:

> This patch adds per-remote target variables for the configuration of
> memory read- and write packet size.  It is a further change to commit
> "gdb: Make global feature array a per-remote target array" to apply the
> fixme notes described in commit 5b6d1e4 "Multi-target support".

Thank you for the patch.

> +  const char* target_type = get_target_type_name (remote != nullptr);

The "*" should be after the space.

> +			      const memory_packet_config* config,

Here too.

> +  memory_packet_config* config = &memory_write_packet_config;

And here... there are a few of these.

This ok with these nits fixed, you don't have to re-send the patch.

Tom

  parent reply	other threads:[~2022-04-18 14:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 13:11 [PATCH v2 0/3] Apply fixme notes for multi-target support Christina Schimpe
2022-03-29 13:11 ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Christina Schimpe
2022-03-29 13:45   ` Eli Zaretskii
2022-04-18 14:56   ` Tom Tromey
2022-04-18 19:01   ` Pedro Alves
2022-04-20 11:30     ` "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Pedro Alves
2022-04-20 11:31     ` Pedro Alves
2022-04-21 10:25       ` Andrew Burgess
2022-04-21 10:31         ` Pedro Alves
2022-04-21 11:01           ` Andrew Burgess
2022-04-21 16:28             ` Andrew Burgess
2022-04-21 18:20               ` Pedro Alves
2022-04-27 13:55     ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Schimpe, Christina
2022-05-25 14:27       ` Pedro Alves
2022-06-01 10:45         ` Schimpe, Christina
2022-03-29 13:11 ` [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config Christina Schimpe
2022-03-29 13:48   ` Eli Zaretskii
2022-04-18 14:56   ` Tom Tromey [this message]
2022-03-29 13:11 ` [PATCH v2 3/3] gdb: Remove workaround for the vCont packet Christina Schimpe
2022-04-18 14:59   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rs2xwxc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).